-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulls wrong image from YouTube, URL also incorrect in 5.1 #63
Comments
A little more on this, it looks like the media_side_load function isn't completing it's job, therefore instead of the URL being |
Willing to help check things where we can, pending some extra feedback :) |
Extra feedback is once I added the PHP snippet to compensate for the 800 character limit, the problems went away :) Don't quite know how you can account for that in the code... but it would be a nice fix. I still have a few sites on 4.9.9 but need to move them to 5.1 for security reasons soon. |
Damn Gutenberg and their hidden markup eating up those characters. |
Yeah, no doubt. |
Related #59 |
There are a couple of issues:
2) In WP 5.1 - the URL to show the thumbnail as a featured image now has the URL of the site in front of it. So instead of http://img.youtube.com/vi/THE-VIDEO-ID/maxresdefault.jpg now the media file shows the siteurl in front of the thumbnail url. The result is a broken link to the thumbnail url.I was able to change the maxresdefault to mqdefault in the php code locally, but I wasn't able to figure out how to change the url that's inserted into the media library to fetch the featured image.
The text was updated successfully, but these errors were encountered: