Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the maximum size of a function body #935

Closed
Ms2ger opened this issue Dec 12, 2018 · 2 comments
Closed

Review the maximum size of a function body #935

Ms2ger opened this issue Dec 12, 2018 · 2 comments

Comments

@Ms2ger
Copy link
Collaborator

Ms2ger commented Dec 12, 2018

The maximum size of a function body, including locals declarations, is 7654321 bytes.

Let's use a round number.

@littledan
Copy link
Collaborator

This constant has some interesting history; see #607 (comment) . It used to be unenforced (in multiple browsers, due to separate bugs!), so it had to be raised to meet web reality.

What's the need for a round number? To me, this one seems as good as any; the important thing is that it be the same everywhere.

@binji
Copy link
Member

binji commented Jan 24, 2019

Agreed that this number is "cute", but since it's (nearly) arbitrary we can afford to be cute here. :-)

Closing, but feel free to reopen if there is more to discuss here.

@binji binji closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants