Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intepreter and test updates from @rossberg #99

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Nov 6, 2024

Interpreter:

  • Fixed evaluation of v128 load/store instructions to work with i64
  • Reworked bulk operation execution to still reduce to well-typed instructions for i32
  • Added missing size check to table allocation
  • Various minor refactorings and clean-ups

Tests:

  • Added tests for size check in i64 table and memory type limits

Split out from WebAssembly/spec#1839

@sbc100 sbc100 requested a review from rossberg November 6, 2024 22:04
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp

Interpreter:

- Fixed evaluation of v128 load/store instructions to work with i64
- Reworked bulk operation execution to still reduce to well-typed instructions for i32
- Added missing size check to table allocation
- Various minor refactorings and clean-ups

Tests:

- Added tests for size check in i64 table and memory type limits

Split out from WebAssembly/spec#1839
@sbc100 sbc100 merged commit 906d452 into main Nov 6, 2024
1 check passed
@sbc100 sbc100 deleted the interp_updates branch November 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants