Feat/nft checkout plugin #2018
Open
Feat/nft checkout plugin #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BboyStatix
reviewed
Nov 21, 2024
| @@ -27,6 +27,7 @@ export type PluginNamespace = (typeof PLUGIN_NAMESPACES)[keyof typeof PLUGIN_NAM | |||
|
|
|||
| export const EVM_PLUGINS = { | |||
| WALLET_SERVICES: "wallet-services", | |||
| NFT_CHECKOUT: "nft-checkout", | |||
There was a problem hiding this comment.
is nft checkout limited to evm?
There was a problem hiding this comment.
What about wallet services?
BboyStatix
reviewed
Nov 21, 2024
| @@ -398,13 +398,13 @@ export class Web3AuthNoModal extends SafeEventEmitter<Web3AuthNoModalEvents> imp | |||
| private connectToPlugins(data: { adapter: WALLET_ADAPTER_TYPE }) { | |||
| Object.values(this.plugins).map(async (plugin) => { | |||
| try { | |||
| if (!plugin.SUPPORTED_ADAPTERS.includes(data.adapter)) { | |||
| if (!plugin.SUPPORTED_ADAPTERS.includes("all") && !plugin.SUPPORTED_ADAPTERS.includes(data.adapter)) { | |||
There was a problem hiding this comment.
I think it may be better to list out all possible adapters instead of a separate value called "all". We can put it in a constant
There was a problem hiding this comment.
we have dynamic adapters (e.g. injected wallet extensions like Metamask...), so cannot list them out.
BboyStatix
reviewed
Nov 21, 2024
| return; | ||
| } | ||
| if (plugin.status === PLUGIN_STATUS.CONNECTED) return; | ||
| const { authInstance } = this.walletAdapters[this.connectedAdapterName] as AuthAdapter; | ||
| const { options, sessionId, sessionNamespace } = authInstance || {}; | ||
| await plugin.initWithWeb3Auth(this, options.whiteLabel); | ||
| await plugin.initWithWeb3Auth(this, options?.whiteLabel); | ||
| await plugin.connect({ sessionId, sessionNamespace }); |
There was a problem hiding this comment.
considering that nft checkout plugin connect function takes no arguments should we update IPlugin interface to make it optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link: https://toruslabs.atlassian.net/browse/PD-3995
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: