Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optimize error messages thrown by schedulis #1083

Closed
2 tasks done
wxyn opened this issue Jul 10, 2023 · 1 comment
Closed
2 tasks done

[Feature] Optimize error messages thrown by schedulis #1083

wxyn opened this issue Jul 10, 2023 · 1 comment
Labels

Comments

@wxyn
Copy link
Contributor

wxyn commented Jul 10, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Problem Description

Nodes in the schedulis project are not allowed to have the same name. When the same name occurs, the error message of the schedulis is not clear, which is difficult for users to understand. Therefore, the error message of the schedulis needs to be parsed, and the expression of the error message needs to be reorganized before it is returned to the user.

Description

As a DSS user, enter the project "test" in DSS, create a new workflow with a node named "start" in the workflow, save the workflow, and publish it.

The same user enters the project "test" again in DSS, creates a new workflow again, has a node named "start", and the node name of the previous workflow, saves the workflow, and then publishes it. You will see "Release failed. The workflow node start has the same name as another workflow node in the project, please rename the node ".

Use case

No response

solutions

  1. Subject logic

1). In SchedulisAppConn, detect the error returned by the schedulis, and if the error copy contains "has ambiguous dependency", the user is prompted to "publish failed". Workflow node ${node name} has the same name as another workflow node in this project. Please rename the node.

2). Node names are extracted through regular matching.

  1. Interface design
    image

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@wxyn wxyn added the enhancement New feature or request label Jul 10, 2023
@zqburde
Copy link
Contributor

zqburde commented Aug 9, 2023

Add it in DSS1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants