Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting Mixed case to one case( toHiragana() ) #39

Closed
tadgh opened this issue Aug 25, 2014 · 2 comments
Closed

Converting Mixed case to one case( toHiragana() ) #39

tadgh opened this issue Aug 25, 2014 · 2 comments

Comments

@tadgh
Copy link

tadgh commented Aug 25, 2014

Working on an app and I've run into this issue where toHiragana won't convert mixed case.
For example:
アメリカ人
if it is typed as:
アメリカじん
and then when converted:

answer = wanakana.toHiragana("アメリカじん")

the answer comes back as アメリカじん

Not sure if this is intended behaviour or not, and I can write around it, but I feel like it would make sense for toHiragana to convert the convertable parts and ignore the already Hiragana parts.

mixed issue

@mimshwright
Copy link
Contributor

I think this may be a (laziness) bug in one of the detection functions like isHiragana(). It's probably not that hard to fix but I unfortunately won't be able to do it for a few weeks since I'm about to have a baby.

Maybe you can try doing a patch and doing a pull request.

Also, let us know what project you build with it!

@tadgh
Copy link
Author

tadgh commented Aug 25, 2014

Thanks for the quick response. I'm not a JS guy but I'll see if I can hack
a patch together. Cheers

@DJTB DJTB closed this as completed in 8038341 Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants