Skip to content
This repository has been archived by the owner on Mar 12, 2021. It is now read-only.

Commit

Permalink
Update cra fork (#2)
Browse files Browse the repository at this point in the history
* Add question issue template (facebook#7423)

* Add question issue template

* Fix bug report template formatting

* Fix bug report template formatting

* Add labels to pull request template

* Update deploy instructions in contributing guide (facebook#7429)

* Update deploy instructions in contributing guide

* Update docs publishing instructions

* Remove labels from pull request template

* Add explicit check for --watchAll=false (facebook#7433)

Resolves facebook#7180.

* Add ESLint 6 support (facebook#7415)

* Update testing-library package names in README (facebook#7340)

* Update ESlint Install Docs (facebook#7451)

* Improve bootstrap docs when using custom SCSS (facebook#7462)

* Added dependencies to bootstrap article when using custom SCSS.

* Make changes to package designation and added npm install directions.

* Suggest `jsx: "react"` in tsconfig (facebook#7472)

* Set jsonpFunction to prevent conflicts (facebook#5951)

* Resolve relative paths for preprocessor styles (facebook#5829)

preprocessor will output sourceMap by default
then check if sourceMaps are needed on resolve-url-loader

Fixes facebook#4653

* Specify roots in Jest config (facebook#7480)

* Optimise templates for Lighthouse (facebook#7482)

* Use readConfigFile instead of require for tsconfig (facebook#7248)

* Fix HMR in Firefox when proxy option present (facebook#7444)

Resolves facebook#6720

* Adjusted deployment documentation for ZEIT Now (facebook#7488)

* Adjusted deployment documentation for ZEIT Now

* Fixed missing word

* Update docusaurus/docs/deployment.md

Co-Authored-By: Joe Haddad <[email protected]>

* Bump dependencies (facebook#7473)

* Support configuring coveragePathIgnorePatterns (facebook#7080)

* Fix RegExp from navigateFallbackBlacklist (workbox) (facebook#7176)

Exclude URLs that contains a "?" character.

* Fix launch.json debugging config (facebook#6484)

* Add vscodium to the editor list (facebook#7028)

* Bump version of sass-loader (facebook#7496)

* Add readonly modifier for css module (facebook#7497)

* Remove unused dependencies in babel-preset-react-app (facebook#5818)

* Remove unused dependencies in babel-preset-react-app

* Re-add @babel/plugin-transform-react-display-name

* Remove some dependencies again

* Prepare 3.1.0 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Add links to Spectrum in README and docs (facebook#7500)

* Update bug report issue template

* Don't block static files in robots.txt (facebook#7508)

* Ignore "jsx-a11y/aria-role" for React components (facebook#7393)

* Update docusaurus config (facebook#7499)

* Update Netlify config (facebook#7527)

* Fix ESLint 6 support (facebook#7513)

* Remove extends restriction to fix ESLint 6 support

* Attempt to resolve CI errors

* Prepare 3.1.1 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Show logo on mobile docs (facebook#7521)

* Show logo for mobile views in create-react-app.dev

* Update docusaurus/website/static/css/custom.css


Co-authored-by: Sabesh Kumar Rajendran <[email protected]>

* Add a migration step to remove static directory from robots.txt (facebook#7536)

* add a migration step to remove static from robots.txt

* Update CHANGELOG.md

Co-Authored-By: Ian Sutherland <[email protected]>

* docs: update Flow documentation (facebook#7550)

* docs: update Flow documentation

* Update adding-flow.md

* Update adding-flow.md

* Correct proxy usage docs (facebook#7368)

* Remove trailing spaces from manifest.json (facebook#7585)

* Link changelogs between major versions (facebook#7613)

* Remove cleanup-after-each example (facebook#7620)

cleanup is called now by default after each test if the testing framework supports the afterEach global

* Adopt Contributor Covenant (facebook#7650)

* Adopt Contributor Covenant

* Add link to Contributor Covenant to docs site

* Fix build (facebook#7662)

* Disable babel-loader's cacheCompression (facebook#7633)

* Update troubleshooting.md (facebook#7459)

* Explicitly check that EXTEND_ESLINT is true (facebook#7538)

* Update running-tests.md (facebook#7659)

* Bump version of @typescript-eslint/* (facebook#7540)

* Upgrade dotenv-expand to fix issues (facebook#7531)

* Minor performance improvements (facebook#7587)

- use ESLint cache
- remove useless `watch` option in fork-ts-checker

* Remove --single-quote from prettier examples (facebook#7663)

* Use const instead of var in env.js (facebook#7526)

* Change runtime chunk name separator from tilde to dash (facebook#7679)

* Bump dependencies (facebook#7681)

* Update deployment.md with another AWS example (facebook#7616)

Add blog post that takes a React developer step-by-step through many features of AWS. Blog post is suitable for a beginner to follow and have a production ready workflow.

* Add new logo (facebook#7704)

* Prepare 3.1.2 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Update runtime chunk name separator in docs (facebook#7705)

* Remove 'shortcut' link type before 'icon' (facebook#7707)

* Guard polyfills against window possibly being undefined (facebook#7205)

* Enable .eslintignore with extend flag (facebook#7562)

* Add "entrypoints" key to asset manifest (facebook#7721)

* Update adding flow documentation (facebook#7731)

* set output.globalObject to 'this' (facebook#7742)

Closes facebook#7741

* Update logic and log errors for EXTEND_ESLINT (facebook#7530)

* update list of supported jest config overrides (facebook#7601)

* Upgrade Webpack version (facebook#7740)

* Close br tags in template README files (facebook#7668)

* Fix variable name casing in fileTransform (facebook#7752)

* Documentation typo fix (facebook#7757)

* Fix linting error when using rest props (facebook#7754)

* Add TSC_COMPILE_ON_ERROR setting (facebook#6931)

* Remove switch case (facebook#7729)

* docs: note that v2 to v3 migration may require deletion of node_modules (facebook#7302)

* Stop hiding the column number of ESLint errors (facebook#6980)

* Support setting baseUrl to root directory (facebook#7755)

* Use installing package manager in README (facebook#7687)

* Support production profiling with React Developer Tools (facebook#7737)

* Added the alias for profiling and output change to keep the classNames and functionNames for human readbility

* defined isEnvProductionProfile with other isEnv checks

* moved the keep_classnames and keep_fnames to terserOptions scope

* resolve merge conflict for yarn.lock.cache

* revert yarn.lock.cache to master yarn.lock.cache
- git checkout origin/master -- packages/create-react-app/yarn.lock.cached

* Comment and Boolean Check
- I clarified the comment and specified the use case
- Changed the environment check to check for the specific true rather than
the assumed primitive value as before.

* Replaced env with flag
- Per suggestion --profile flag used instead of env variable PROFILE_APP

* documentation in available scripts section with suggested information

* resolved a local git issue. Fixed documentation error.

* moved documentation to suggested file
- Added a brief summary of profiling in available scripts section.
The summary references the production-build document. Which is the
file I moved the new documentation into under a new Header for production support.

* Update production-build.md


Co-authored-by: Ian Sutherland <[email protected]>

* Prepare 3.2.0 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Temporarily disable Windows in CI (facebook#7773)

* Add babel runtime version to transform-runtime plugin to reduce… (facebook#7726)

* Add Babel sourcemap to resolve VSCode debugging issues (facebook#7022)

* Fix process type in TypeScript template (facebook#7796)

* Account for browserslist environment variables (facebook#7764)

* Clarify dynamic import stage in docs (facebook#7813)

* Update adding-typescript.md (facebook#7815)

* Document how to use the .env file to enforce HTTPS (facebook#7821)

* Fix absolute paths issue in Jest (facebook#7822)

* Document correct default behavior for HOST var (facebook#7823)

* Fix grammar error in troubleshooting.md (facebook#7824)

* Upgrade to docusaurus 2 (facebook#7785)

* chore: upgrade to docusaurus 2

* address review

* Update doc publishing instructions

* Revert logo in templates (facebook#7830)

* feat: add additional Jest keys to whitelist (facebook#7832)

* Link to React documentation for code splitting (facebook#7686)

The official documentation offers a simpler way of achieving route based code splitting.

* Add a note about .eslingignore files being respected (facebook#7809)

* added check for typescript template and unsupported node version (facebook#7839)

* added check for typescript template and unsupported node version

* addressed code review feedback regarding syntax and spelling mistakes

* Update getting-started.md (facebook#7841)

Update the initial project structure generated by create-react-app.

* Link to ASP.NET Core docs (facebook#7840)

* Update readme gif links (facebook#7849)

* Update adding-bootstrap.md (facebook#7853)

typo fix

* Move unused eslint webpack import into @remove-on-eject block (facebook#7856)

* 📖 DOC: Improvement (facebook#7819)

* Upgrade terser & enable parallel minification in wsl (facebook#7857)

* Add a GitHub Action that runs the build script (facebook#7861)

* Edit InterpolateHtmlPlugin hook (facebook#6448) (facebook#6449)

* Fix notations of loopback addresses (facebook#7474)

* Add Service-Worker header to checkValidServiceWorker (facebook#6753)

* Add header to checkValidServiceWorker (ts)

* Add header to checkValidServiceWorker

* Add additional information for postcss errors (facebook#6282) (facebook#6352)

* Add additional information for postcss errors

* Add additional information for postcss errors (simplify)

* Remove chunkname from postCSS compile error

* Remove line number from postCSS compile error

* Fix eslint complaints in build.js (facebook#7870)

* Add Alex to lint documentation (facebook#7852)

* Add Alex to lint documentation

* Attempt to trigger GitHub Action

* Configure Alex and update docs

* More docs updates

* Bump docusaurus 🦖 (facebook#7874)

* Dark scheme overlay (facebook#7052)

* Bump react (facebook#7875)

* Bump styling related loaders (facebook#7876)

* Remove alex precommit check (facebook#7878)

* Add template support (facebook#7716)

* Add template support

* Update templates version check

* Update TypeScript template README

* Prepare 3.3.0 beta

* If template name already starts with cra-template leave it alone (facebook#7880)

* Update prerelease publishing instructions

* Upgrade packages and tweak config to adapt to new config format (facebook#7814)

Rebased again now with smaller changes in this one which will make it easier to revert in case of eventual regressions.

* refactor: remove double coerce (facebook#7882)

* Add yarn.lock to .gitignore (facebook#7789)

* chore: Fix broken link for CRA deployment (facebook#7897)

* chore: Fix broken link for e2e README (facebook#7896)

* Add @testing-library to the default templates (facebook#7881)

* Add numeric separator support (facebook#7817)

* Update open (facebook#7910)

* Mark TypeScript as an optional peer dependency (facebook#7860)

* Add restoreMocks to supported jest config keys (facebook#7921)

* fix seperators typo (facebook#7932)

Its the little things that makes the big difference!  😁

Thanks

* No spinning React logo if `prefers-reduced-motion` (facebook#7931)

* Made PRs welcome badge point to contributors guide (facebook#7792)

* Make JavaScript and TypeScript templates consistent (facebook#7944)

* Fix CI (facebook#7951)

* Add optional chaining and nullish coalescing operators support (facebook#7438)

* Add tests for optional chaining and null coalescing (facebook#7952)

* Upgrade jest-watch-typeahead (facebook#7956)

* Fix light background in docusaurus night mode (facebook#7936)

* Fix light background in docusaurus night mode

Closes facebook#7930

* Rename lightBackground to gettingStartedSection

* Add placeholders where old template READMEs used to be (facebook#7972)

* Temporarily disable GitHub Actions (facebook#7978)

* Prepare 3.3.0 beta

* Bump dependencies (facebook#7986)

* Support scoped templates (facebook#7991)

* Add contributors section to readme (facebook#7995)

* added e2e test for checking typescript template with unsupported node (facebook#7844)

* Unpin dependencies in react-app-polyfill (facebook#7999)

* Add scripts support to templates (facebook#7989)

* Override no-unused-expressions with the typescript-eslint version (facebook#8003)

Fixes issues with optional chaining

* Prefix apple-touch-icon links with PUBLIC_URL. (facebook#8005)

* Bump webpack-dev-server (facebook#7988)

* Bump dependencies (facebook#8024)

* Re-enable GitHub Actions (facebook#8029)

* Update CHANGELOG

* Update CODEOWNERS

* Remove no-unexpected-multiline rule (facebook#8039)

* Add TypeScript peer dependency to react-scripts (facebook#8038)

* Update template docs (facebook#8050)

* Update template docs

* Update custom-templates.md

* Update custom-templates.md


Co-authored-by: Ian Sutherland <[email protected]>

* Prepare 3.3.0 release

* Update CHANGELOG

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* webpackHotDev now uses wss when https is used (facebook#8079)

* Add custom-templates to docs sidebar (facebook#8077)

* Fix typo in CHANGELOG.md (facebook#8080)

* Remove error for @typescript-eslint/no-namespace (facebook#7803)

Declare namespaces are supported by babel now, and babel will throw with a nice error message for non-declare namespaces, so this rule is unnecessary. Closes facebook#7651.

* Fix CI build (facebook#8122)

* Fix CSS font-face minification (facebook#8106)

* Add slashes to WebSocket protocol URL (facebook#8116)

* Fix typo in comment: `?.` is right, not `.?` (facebook#8124)

This is just a comment fix.

Actual optional chaining operator syntax is `?.`, not `.?`.

* chore: update docusaurus & tweak site (facebook#8111)

* [Security] Update terser webpack plugin (facebook#8102)

* security: update terser webpack plugin

* feat(react-scripts): allow PUBLIC_URL in develoment mode

* Add current version and bin location to --info output (facebook#8168)

Make the --info subcommand outuput the current version information and the location of the file being run. Our issue template tells users to provide the output of --info, so having the current version is incredibly helpful, especially since it doesn't necessarily match the globally installed version that envinfo outputs. Knowing the location helps us determine whether the running bin is globally installed or in the local node_modules.

* Bump pkgUp (facebook#8163)

* Bump chalk (facebook#8164)

* Add link to Netlify in README

* Bump internal dependencies (facebook#8176)

* Bump dependencies in react-dev-utils

* Bump dependencies in react-app-polyfill

* Bump dependencies in create-react-app

* Bump dependencies in react-error-overlay

* Bump dependencies in react-scripts

* Bump react

* Add package-runner note to readme (facebook#8132)

* Add package-runner note to readme

* Add link to `yarn create`

* Update PWA docs links to point to template package (facebook#8147)

* Minor refactors in create-react-app (facebook#8178)

- Remove templates version minimum stopgap.
- Replace indexOf with more idiomatic alternatives.
- Inline errorLogFilePatterns.
- Alphabetize validFiles.
- Simplify log file removal code.
- Move unconditional console.log() call outside of isSafe.
- Differentiate conflicting directories from files.
- Document yarn version special case.
- Inline printValidationResults.
- Standardize checkAppName output on failure.
- Add link for checkThatNpmCanReadCwd.

Functionally the code should be exactly the same.

* fix: proactively append to .gitignore during init (facebook#8028)

* Bump babel-plugin-tester and fix breaking changes (facebook#8171)

* feat(react-scripts): allow PUBLIC_URL in develoment mode

Co-authored-by: Eric Clemmons <[email protected]>
Co-authored-by: Alex Guerra <[email protected]>

* A few small corrections

* webpackdevserver quiet setting -> false

Co-authored-by: Ian Sutherland <[email protected]>
Co-authored-by: Brody McKee <[email protected]>
Co-authored-by: Balázs Orbán <[email protected]>
Co-authored-by: Chuck  <[email protected]>
Co-authored-by: Darius Tall <[email protected]>
Co-authored-by: Sibiraj <[email protected]>
Co-authored-by: Andrew Luca <[email protected]>
Co-authored-by: Igor Muchychka <[email protected]>
Co-authored-by: dominic scanlan <[email protected]>
Co-authored-by: Jack Cross <[email protected]>
Co-authored-by: Dmitry Lepskiy <[email protected]>
Co-authored-by: Leo Lamprecht <[email protected]>
Co-authored-by: Joe Haddad <[email protected]>
Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Kent C. Dodds <[email protected]>
Co-authored-by: Andrea Puddu <[email protected]>
Co-authored-by: Ryan Marsh <[email protected]>
Co-authored-by: Leonardo Dino <[email protected]>
Co-authored-by: ZHAO Jinxiang <[email protected]>
Co-authored-by: Tomáš Szabo <[email protected]>
Co-authored-by: Sabesh Rajendran <[email protected]>
Co-authored-by: Jon Stevens <[email protected]>
Co-authored-by: Federico Zivolo <[email protected]>
Co-authored-by: szabi <[email protected]>
Co-authored-by: Emil Pålsson <[email protected]>
Co-authored-by: iHmD <[email protected]>
Co-authored-by: Jerome Leclanche <[email protected]>
Co-authored-by: Clément Prévost <[email protected]>
Co-authored-by: Brock Wills <[email protected]>
Co-authored-by: Weyert de Boer <[email protected]>
Co-authored-by: pierreneter <[email protected]>
Co-authored-by: Dominic Tobias <[email protected]>
Co-authored-by: brlewis <[email protected]>
Co-authored-by: Jannis Hell <[email protected]>
Co-authored-by: Doug Ross <[email protected]>
Co-authored-by: Andrew <[email protected]>
Co-authored-by: Samuel Meuli <[email protected]>
Co-authored-by: Lewis Llobera <[email protected]>
Co-authored-by: Jake Moxey <[email protected]>
Co-authored-by: Iguchi Tomokatsu <[email protected]>
Co-authored-by: Laurin Quast <[email protected]>
Co-authored-by: neilbryson <[email protected]>
Co-authored-by: Reece Dunham <[email protected]>
Co-authored-by: Rakan Nimer <[email protected]>
Co-authored-by: Tomer Cohen <[email protected]>
Co-authored-by: Alexandr Tovmach <[email protected]>
Co-authored-by: Kyle Bebak <[email protected]>
Co-authored-by: André Lins <[email protected]>
Co-authored-by: Kim Persson <[email protected]>
Co-authored-by: Justin Grant <[email protected]>
Co-authored-by: Robert van Steen <[email protected]>
Co-authored-by: Ashrith Reddy <[email protected]>
Co-authored-by: Jacob M-G Evans <[email protected]>
Co-authored-by: Damian Senn <[email protected]>
Co-authored-by: Róbert FUSZENECKER <[email protected]>
Co-authored-by: May <[email protected]>
Co-authored-by: Orta <[email protected]>
Co-authored-by: Tomáš Hübelbauer <[email protected]>
Co-authored-by: Jesse Jackson <[email protected]>
Co-authored-by: Jake Boone <[email protected]>
Co-authored-by: Endi <[email protected]>
Co-authored-by: Hugo David-Boyet <[email protected]>
Co-authored-by: Sean Lafferty <[email protected]>
Co-authored-by: Ali Waseem <[email protected]>
Co-authored-by: reactjser <[email protected]>
Co-authored-by: Daniel Lo Nigro <[email protected]>
Co-authored-by: Chun <[email protected]>
Co-authored-by: Xuhao <[email protected]>
Co-authored-by: Sean Baines <[email protected]>
Co-authored-by: Abdul Wahab ⚡️ <[email protected]>
Co-authored-by: Guillaume Hertault <[email protected]>
Co-authored-by: Wataru Ashihara <[email protected]>
Co-authored-by: darthmaim <[email protected]>
Co-authored-by: Joshua Robinson <[email protected]>
Co-authored-by: Andreas Cederström <[email protected]>
Co-authored-by: Fabiano Brito <[email protected]>
Co-authored-by: Kanitkorn Sujautra <[email protected]>
Co-authored-by: Havit Rovik <[email protected]>
Co-authored-by: Tharun Rajendran <[email protected]>
Co-authored-by: Dylan Staley <[email protected]>
Co-authored-by: Donavon West <[email protected]>
Co-authored-by: James George <[email protected]>
Co-authored-by: RJ <[email protected]>
Co-authored-by: Renato Augusto Gama dos Santos <[email protected]>
Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: Alex Guerra <[email protected]>
Co-authored-by: Klas Björkqvist <[email protected]>
Co-authored-by: Max Davidson <[email protected]>
Co-authored-by: Ben Blank <[email protected]>
Co-authored-by: Mike Caulley <[email protected]>
Co-authored-by: Trontor <[email protected]>
Co-authored-by: Sean Zhu <[email protected]>
Co-authored-by: Simon Donaldson <[email protected]>
Co-authored-by: Wojciech Zieliński <[email protected]>
Co-authored-by: Vadzim <[email protected]>
Co-authored-by: Eric Clemmons <[email protected]>
Co-authored-by: Jerome De Leon <[email protected]>
Co-authored-by: Peet Goddard <[email protected]>
Co-authored-by: Brian Muenzenmeyer <[email protected]>
  • Loading branch information
Show file tree
Hide file tree
Showing 307 changed files with 13,269 additions and 8,001 deletions.
4 changes: 4 additions & 0 deletions .alexignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
build

CHANGELOG*
CODE_OF_CONDUCT.md
18 changes: 18 additions & 0 deletions .alexrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"allow": [
"attacks",
"colors",
"conservative",
"crashes",
"executed",
"executes",
"execution",
"failed",
"hook",
"host-hostess",
"hostesses-hosts",
"invalid",
"remain",
"watchman-watchwoman"
]
}
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
packages/ @amyrlam @bugzpodder @gaearon @ianschmitz @iansu @mrmckeb @petetnt @timer
packages/ @ianschmitz @iansu @mrmckeb @petetnt
docusaurus/ @amyrlam @iansu
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Bug report
about: Create a report to help us improve
labels: 'issue: bug'
labels: 'issue: bug report, needs triage'
---

<!--
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/proposal.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Proposal
about: Suggest an idea for improving Create React App
labels: 'issue: proposal'
labels: 'issue: proposal, needs triage'
---

### Is your proposal related to a problem?
Expand Down
13 changes: 13 additions & 0 deletions .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
name: Question
about: Get help with Create React App
labels: 'needs triage'
---

If you have a general question about Create React App or about building an app with Create React App we encourage you to post on our Spectrum community instead of this issue tracker. The maintainers and other community members can provide help and answer your questions there: https://spectrum.chat/create-react-app

If you're looking for general information on using React, the React docs have a list of resources: https://reactjs.org/community/support.html

If you've discovered a bug or would like to propose a change please use one of the other issue templates.

Thanks!
13 changes: 13 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Build

on: [push]

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Install
run: yarn --no-progress --non-interactive --no-lockfile
- name: Build
run: yarn build
13 changes: 13 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Lint

on: [push]

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Install
run: yarn --no-progress --non-interactive --no-lockfile
- name: Alex
run: yarn alex
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ yarn-debug.log*
yarn-error.log*
/.changelog
.npm/
yarn.lock
14 changes: 7 additions & 7 deletions CHANGELOG-1.x.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## 2.0.3 and Newer Versions

**Please refer to [CHANGELOG.md](./CHANGELOG.md) for the newer versions.**
**Please refer to [CHANGELOG-2.x.md](./CHANGELOG-2.x.md) for the 2.x range, and [CHANGELOG.md](CHANGELOG.md) for the newer versions.**

## 1.1.5 (August 24, 2018)

Expand Down Expand Up @@ -1577,20 +1577,20 @@ Unhandled Promise rejections will now crash tests. You can fix them by explicitl
After the regular update procedure above, add these line to `<head>` in `public/index.html`:

```html
<meta name="theme-color" content="#000000">
<!--
<meta name="theme-color" content="#000000" />
<!--
manifest.json provides metadata used when your web app is added to the
homescreen on Android. See https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/
-->
<link rel="manifest" href="%PUBLIC_URL%/manifest.json">
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
```

Add `<noscript>` to `<body>` in `public/index.html`:

```html
<noscript>
You need to enable JavaScript to run this app.
</noscript>
<noscript>
You need to enable JavaScript to run this app.
</noscript>
```

Then create a file called `public/manifest.json` that looks like this:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG-2.x.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.0.0 and Newer Versions

**Please refer to [CHANGELOG.md](./CHANGELOG.md) for the newer versions.**

## 2.1.8 (March 7, 2019)

v2.1.8 is a maintenance release that reapplies the TypeScript speed improvements ([#6406](https://github.com/facebook/create-react-app/pull/6406)) in a new major version of `react-dev-utils`.
Expand Down
651 changes: 651 additions & 0 deletions CHANGELOG.md

Large diffs are not rendered by default.

75 changes: 74 additions & 1 deletion CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,76 @@
# Code of Conduct

Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please [read the full text](https://code.fb.com/codeofconduct/) so that you can understand what actions will and will not be tolerated.
## Our Pledge

In the interest of fostering an open and welcoming environment, we as
contributors and maintainers pledge to make participation in our project and
our community a harassment-free experience for everyone, regardless of age, body
size, disability, ethnicity, sex characteristics, gender identity and expression,
level of experience, education, socio-economic status, nationality, personal
appearance, race, religion, or sexual identity and orientation.

## Our Standards

Examples of behavior that contributes to creating a positive environment
include:

- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

- The use of sexualized language or imagery and unwelcome sexual attention or
advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic
address, without explicit permission
- Other conduct which could reasonably be considered inappropriate in a
professional setting

## Our Responsibilities

Project maintainers are responsible for clarifying the standards of acceptable
behavior and are expected to take appropriate and fair corrective action in
response to any instances of unacceptable behavior.

Project maintainers have the right and responsibility to remove, edit, or
reject comments, commits, code, wiki edits, issues, and other contributions
that are not aligned to this Code of Conduct, or to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,
threatening, offensive, or harmful.

## Scope

This Code of Conduct applies within all project spaces, and it also applies when
an individual is representing the project or its community in public spaces.
Examples of representing a project or community include using an official
project e-mail address, posting via an official social media account, or acting
as an appointed representative at an online or offline event. Representation of
a project may be further defined and clarified by project maintainers.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team at <[email protected]>. All
complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The project team is
obligated to maintain confidentiality with regard to the reporter of an incident.
Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by other
members of the project's leadership.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html

[homepage]: https://www.contributor-covenant.org

For answers to common questions about this code of conduct, see
https://www.contributor-covenant.org/faq
33 changes: 22 additions & 11 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Loving Create React App and want to get involved? Thanks! There are plenty of ways you can help.

Please take a moment to review this document in order to make the contribution process easy and effective for everyone involved.
Please take a moment to review this document in order to make the contribution process straightforward and effective for everyone involved.

Following these guidelines helps to communicate that you respect the time of the developers managing and developing this open source project. In return, they should reciprocate that respect in addressing your issue or assessing patches and features.

Expand All @@ -15,23 +15,27 @@ Here are a few examples of them in action.

### Convention

<!--alex disable easy-->

Instead of letting the user specify the entry filename, we always assume it to be `src/index.js`. Rather than letting the user specify the output bundle name, we generate it, but make sure to include the content hash in it. Whenever possible, we want to leverage convention to make good choices for the user, especially in cases where it’s easy to misconfigure something.

### Heuristics

Normally, `npm start` runs on port `3000`, and this is not explicitly configurable. However, some environments like cloud IDEs want the programs to run on a specific port to serve their output. We want to play well with different environments, so Create React App reads `PORT` environment variable and prefers it when it is specified. The trick is that we know cloud IDEs already specify it automatically, so there is no need for the user to do anything. Create React App relies on heuristics to do the right thing depending on environment.

<!--alex disable just-->

Another example of this is how `npm test` normally launches the watcher, but if the `CI` environment variable is set, it will run tests once. We know that popular CI environments set this variable, so the user doesn’t need to do anything. It just works.

### Interactivity

We prefer to add interactivity to the command line interface rather than add configuration flags. For example, `npm start` will attempt to run with port `3000` by default, but it may be busy. Many other tools just fail in this case and ask that you pass a different port, but Create React App will display a prompt asking if you’d like to run the app on the next available port.
We prefer to add interactivity to the command line interface rather than add configuration flags. For example, `npm start` will attempt to run with port `3000` by default, but it may be busy. Many other tools fail in this case and ask that you pass a different port, but Create React App will display a prompt asking if you’d like to run the app on the next available port.

Another example of interactivity is `npm test` watcher interface. Instead of asking people to pass command line flags for switching between test runner modes or search patterns, we print a hint with keys that you can press during the test session to instruct watcher what to do. Jest supports both flags and interactive CLI but Create React App prefers long-running sessions to keep user immersed in the flow over short-running sessions with different flags.

### Breaking the Rules

No rules are perfect. Sometimes we may introduce flags or configuration if we believe the value is high enough to justify the mental cost. For example, we know that apps may be hosted paths different from the root, and we need to support this use case. However, we still try to fall back to heuristics when possible. In this example, we ask that you specify `homepage` in `package.json`, and infer the correct path based on it. We also nudge the user to fill out the `homepage` after the build, so the user becomes aware that the feature exists.
No rules are perfect. Sometimes we may introduce flags or configuration if we believe the value is high enough to justify the complexity. For example, we know that apps may be hosted paths different from the root, and we need to support this use case. However, we still try to fall back to heuristics when possible. In this example, we ask that you specify `homepage` in `package.json`, and infer the correct path based on it. We also nudge the user to fill out the `homepage` after the build, so the user becomes aware that the feature exists.

## Submitting a Pull Request

Expand Down Expand Up @@ -76,7 +80,7 @@ This package is enabled by default for all `create-react-app` scaffolded applica

#### [react-dev-utils](https://github.com/facebook/create-react-app/tree/master/packages/react-dev-utils)

This package contains utilities used for `react-scripts` and sister packages.<br>
This package contains utilities used for `react-scripts` and sibling packages.<br>
Its main purpose is to conceal code which the user shouldn't be burdened with upon ejecting.

#### [react-scripts](https://github.com/facebook/create-react-app/tree/master/packages/react-scripts)
Expand All @@ -90,7 +94,7 @@ All functionality must be retained (and configuration given to the user) if they

2. Run `yarn` in the root `create-react-app` folder.

Once it is done, you can modify any file locally and run `yarn start`, `yarn test` or `yarn build` just like in a generated project.
Once it is done, you can modify any file locally and run `yarn start`, `yarn test` or `yarn build` like you can in a generated project.

If you want to try out the end-to-end flow with the global CLI, you can do this too:

Expand All @@ -105,15 +109,15 @@ and then run `yarn start` or `yarn build`.

**TL;DR** use the command `yarn e2e:docker` to run unit and e2e tests.

More detailed information are in the dedicated [README](/packages/react-scripts/fixtures/kitchensink/README.md).
More detailed information are in the dedicated [README](/test/README.md).

### CI testing with private packages

**create-react-app** relies on main registry to fetch all dependencies, but, if you are in the need to usage of custom private packages that need to be fetch while running E2E test you might need a different configuration.

#### Customizing E2E registry configuration

We use [verdaccio](https://github.com/verdaccio/verdaccio) to emulate packages publishing in a registry using a default configuration. You might modify the current behaviour just editing the file `task/verdaccio.yaml`.
We use [verdaccio](https://github.com/verdaccio/verdaccio) to emulate packages publishing in a registry using a default configuration. You might modify the current behaviour by editing the file `task/verdaccio.yaml`.

For more information about the configuration check out the [Verdaccio documentation](https://verdaccio.org/docs/en/configuration).

Expand All @@ -135,8 +139,8 @@ By default git would use `CRLF` line endings which would cause the scripts to fa

## Cutting a Release

1. Tag all merged pull requests that go into the release with the relevant milestone. Each merged PR should also be labeled with one of the [labels](https://github.com/facebook/create-react-app/labels) named `tag: ...` to indicate what kind of change it is.
2. Close the milestone.
1. Tag all merged pull requests that go into the release with the relevant milestone. Each merged PR should also be labeled with one of the [labels](https://github.com/facebook/create-react-app/labels) named `tag: ...` to indicate what kind of change it is. **Make sure all breaking changes are correctly labelled with `tag: breaking change`.**
2. Close the milestone and create a new one for the next release.
3. In most releases, only `react-scripts` needs to be released. If you don’t have any changes to the `packages/create-react-app` folder, you don’t need to bump its version or publish it (the publish script will publish only changed packages).
4. Note that files in `packages/create-react-app` should be modified with extreme caution. Since it’s a global CLI, any version of `create-react-app` (global CLI) including very old ones should work with the latest version of `react-scripts`.
5. Run `yarn compile:lockfile`. The command will generate an updated lockfile in `packages/create-react-app` that should be committed.
Expand All @@ -148,11 +152,18 @@ By default git would use `CRLF` line endings which would cause the scripts to fa
- Maybe add some newlines here and there. Preview the result on GitHub to get a feel for it. Changelog generator output is a bit too terse for my taste, so try to make it visually pleasing and well grouped.

7. Make sure to include “Migrating from ...” instructions for the previous release. Often you can copy and paste them.
8. Run `npm run publish`. (It has to be `npm run publish` exactly, not just `npm publish` or `yarn publish`.)
8. Run `npm run publish`. (It has to be `npm run publish` exactly, not `npm publish` or `yarn publish`.)
9. Wait for a long time, and it will get published. Don’t worry that it’s stuck. In the end the publish script will prompt for versions before publishing the packages.
10. After publishing, create a GitHub Release with the same text as the changelog entry. See previous Releases for inspiration.

Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- prepatch --canary --preid next --dist-tag next --npm-client npm --force-publish` instead of `npm run publish`.
Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- --canary --exact --preid next --dist-tag=next --force-publish=* minor` instead of `npm run publish`.

## Releasing the Docs

1. Go to the `docusaurus/website` directory
2. Run `yarn build`
3. You'll need an [access token for the GitHub API](https://help.github.com/articles/creating-an-access-token-for-command-line-use/). Save it to this environment variable: `export GITHUB_AUTH="..."`
4. Run `GIT_USER=<GITHUB_USERNAME> CURRENT_BRANCH=master USE_SSH=true yarn deploy`

---

Expand Down
Loading

0 comments on commit d4d5df6

Please sign in to comment.