-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ionic and Shannon radii handling #27
Comments
In response to problem 1: From Shannon, R. D. (1976). Acta Cryst. A32, 751-767., the ionic radii do indeed depend on the coordination environment. The difference between the shannon (referred to as crystal within shannon_radii.csv) and ionic radii are is that the crystal radius is based on r(VIO2-)=1.26 and r(VIF-)=1.19Å and that ionic radius is based on r(VIO2-)=1.40Å. Crystal radii correspond more closely to the physical size of ions. In response to problem 2: We could also make the default coordination for a species, the most abundant coordination environment for that species by adding the relative abundance to the shannon_radii.csv file using the analysis from the following paper: In response to problem 3: I can work on implementing your suggestions. Let me know what you think about the points I've raised. |
You seem to be right about problem 1 looking again at the original reference. I think my confusion comes from the fact that in pymatgen it is possible to get an ionic radius as long as you have an element + oxidation state, but to get a Shannon radius you need to also supply a coordination environment. I'm not 100% sure how ionic radii are decided upon though. In general, I'm fairly sure that Shannon radii in pymatgen == Effective radii in the Shannon paper, and Ionic radii == Crystal radii in the Shannon paper. It would be good to keep the terminology as consistent as possible with codes like pymatgen.
^ I really like this idea, I think it would make a lot of sense! And for problem 3, I think that's a good idea to clarify the coordination. Again, we could take a leaf out of pymatgen's book who use some convention with roman numerals. Thinking about all this, I'm wondering whether it would make more sense to rely more heavily on the pymatgen.core.periodic_table module within SMACT in general, as pymatgen is a dependency anyway... |
The way that ionic and Shannon radii of Species are handled is confusing. There are several related problems:
problem 1:
Species currently have:
(*If you subscribe to the idea that having one average ionic radius for each Species is a useful quantity.)
E.g. Different Shannon radii can be accessed for Ba:
But so can different ionic radii:
The data is loaded from
shannon_radii.csv
which contains multiple ionic radii for each Species, e.g.:Problem 2:
When no 'coordination' is supplied, it is not obvious which ionic radius is chosen in
shannon_radii.csv
. In many screening studies we do not want to specify specific coordination environments and are interested in an average or typical value. E.g for Fe2+ the square planar ionic radius is selected:shannon_radii.csv
:Problem 3:
It's not (obviously) possible to distinguish between Shannon radii for square planar and tetrahedral environments because 'coordination' is supplied as an integer, e.g.:
shannon_radii.csv
:Problem 4:
There is a file called
ionic_radii.csv
lurking around indata/
that as far as I can tell is no longer used for anything.Suggestions:
shannon_radii.csv
that indicates a default coordination environment for each Species.The text was updated successfully, but these errors were encountered: