Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common functions from edit-profile to parent class #2906

Open
hirokiterashima opened this issue Jan 26, 2021 · 0 comments
Open

Extract common functions from edit-profile to parent class #2906

hirokiterashima opened this issue Jan 26, 2021 · 0 comments
Labels
2 points can be completed in 2 hours Code Quality
Milestone
5.22

Comments

@hirokiterashima
Copy link
Member

Teacher and student users have their own edit-profile component class that share similar blocks of code. Try to reduce the remediation time by at least 2 days by extracting the duplicate code into a parent class.

https://codeclimate.com/github/WISE-Community/WISE/src/main/webapp/site/src/app/student/account/edit-profile/edit-profile.component.spec.ts
https://codeclimate.com/github/WISE-Community/WISE/src/main/webapp/site/src/app/teacher/account/edit-profile/edit-profile.component.spec.ts
https://codeclimate.com/github/WISE-Community/WISE/src/main/webapp/site/src/app/teacher/account/edit-profile/edit-profile.component.ts
@hirokiterashima hirokiterashima added 2 points can be completed in 2 hours Code Quality labels Jan 26, 2021
@hirokiterashima hirokiterashima added this to the 5.22 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 points can be completed in 2 hours Code Quality
Projects
None yet
Milestone
5.22
Development

No branches or pull requests
1 participant
@hirokiterashima