Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON error for certain units when locking/unlocking lessons #2749

Open
breity opened this issue Oct 23, 2020 · 0 comments
Open

JSON error for certain units when locking/unlocking lessons #2749

breity opened this issue Oct 23, 2020 · 0 comments
Labels
Milestone

Comments

@breity
Copy link
Member

breity commented Oct 23, 2020

Description

Certain projects fail to lock or unlock lessons. Haven't been able to determine what causes this, as onnly specific units have the problem. Has something to do with unit json, as AngularJS throws this error:

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Subscriber'
    |     property '_subscriptions' -> object with constructor 'Array'
    |     index 0 -> object with constructor 'SubjectSubscription'
    --- property '_parentOrParents' closes the circle
    at Object.stringify (<anonymous>)
    at Object.toJson (angular.js:1458)
    at TeacherProjectService.saveProject (projectService.ts:1144)
    at NavItemController.toggleLockNode (navItem.ts:293)
    ...

Steps to Reproduce

  1. Log in as a teacher and launch Teacher Tools for a run.
  2. Click the lock icon on one of the lessons.
  3. Locking will fail for units that have this problem and you'll see the above error in the console.
@breity breity added the Bug label Oct 23, 2020
@breity breity added this to the 5.16 milestone Oct 23, 2020
@hirokiterashima hirokiterashima modified the milestones: 5.16, 5.18 Oct 28, 2020
@hirokiterashima hirokiterashima modified the milestones: 5.19, 5.21 Dec 10, 2020
@hirokiterashima hirokiterashima modified the milestones: 5.21, 5.22 Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants