Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Should onlyExternal use a different default? #21

Open
sicking opened this issue Apr 14, 2016 · 1 comment
Open

Should onlyExternal use a different default? #21

sicking opened this issue Apr 14, 2016 · 1 comment

Comments

@sicking
Copy link

sicking commented Apr 14, 2016

As things are defined right now, there's a slight risk that pages will not know about onlyExternal and do their own filtering, which would be less performant than using onlyExternal.

So if we switch to onlyExternal defaulting to true (or, more likely, switch its name to includeInternal and keep the default as false), there's a greater chance that developers will write code that has best performance.

However, it'd also be really annoying if essentially everyone has to override the default. So if we think that it's going to be far more common to want to be notified about same-connection changes, then we should probably leave things as-is.

Do we have a sense for what will be the most common behavior?

@dmurph
Copy link
Collaborator

dmurph commented Apr 18, 2016

This is a great question. Personally, I would hook my UI up to just the database all the time, so I would want onlyExternal to be false, but I'm also not a frontend developer. I'll ask around to potential users to see what their most common use-case is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants