Properly specify async iterable behavior. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnall
approved these changes
May 5, 2020
| No guarantees are given either way. | ||
| </div> | ||
|
|
||
| Advisement: In Chrome this is currently implemented as a `directoryHandle.getEntries()` method that can be used in a `for await..of` loop. |
There was a problem hiding this comment.
Would we fix this in Chrome 84? If so, should we call this out?
There was a problem hiding this comment.
We should definitely update this to mention the milestone chrome implements this, when we know what milestone that is. Not sure currently if that is going to 84 branching next week, but I suspect not. So leaving it like this for now.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 18, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 23, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 15, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 15, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 16, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 16, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 20, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 20, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 20, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 20, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 21, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Marijn Kruisselbrink <[email protected]> Cr-Commit-Position: refs/heads/master@{#790486}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 21, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Marijn Kruisselbrink <[email protected]> Cr-Commit-Position: refs/heads/master@{#790486}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Jul 21, 2020
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Marijn Kruisselbrink <[email protected]> Cr-Commit-Position: refs/heads/master@{#790486}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 24, 2020
…match spec., a=testonly Automatic update from web-platform-tests [NativeFS] Update async iterable API to match spec. Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Marijn Kruisselbrink <[email protected]> Cr-Commit-Position: refs/heads/master@{#790486} -- wpt-commits: 6dd4527974f68f3c904efb3910899ef641358c2e wpt-pr: 24219
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 25, 2020
…match spec., a=testonly Automatic update from web-platform-tests [NativeFS] Update async iterable API to match spec. Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Marijn Kruisselbrink <[email protected]> Cr-Commit-Position: refs/heads/master@{#790486} -- wpt-commits: 6dd4527974f68f3c904efb3910899ef641358c2e wpt-pr: 24219
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Aug 1, 2020
…match spec., a=testonly Automatic update from web-platform-tests [NativeFS] Update async iterable API to match spec. Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <taptedchromium.org> Reviewed-by: Yuki Shiino <yukishiinochromium.org> Commit-Queue: Marijn Kruisselbrink <mekchromium.org> Cr-Commit-Position: refs/heads/master{#790486} -- wpt-commits: 6dd4527974f68f3c904efb3910899ef641358c2e wpt-pr: 24219 UltraBlame original commit: e170aa29bb984ad26a9b782ee493c7def30a1fe6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Aug 1, 2020
…match spec., a=testonly Automatic update from web-platform-tests [NativeFS] Update async iterable API to match spec. Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <taptedchromium.org> Reviewed-by: Yuki Shiino <yukishiinochromium.org> Commit-Queue: Marijn Kruisselbrink <mekchromium.org> Cr-Commit-Position: refs/heads/master{#790486} -- wpt-commits: 6dd4527974f68f3c904efb3910899ef641358c2e wpt-pr: 24219 UltraBlame original commit: e170aa29bb984ad26a9b782ee493c7def30a1fe6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Aug 1, 2020
…match spec., a=testonly Automatic update from web-platform-tests [NativeFS] Update async iterable API to match spec. Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <taptedchromium.org> Reviewed-by: Yuki Shiino <yukishiinochromium.org> Commit-Queue: Marijn Kruisselbrink <mekchromium.org> Cr-Commit-Position: refs/heads/master{#790486} -- wpt-commits: 6dd4527974f68f3c904efb3910899ef641358c2e wpt-pr: 24219 UltraBlame original commit: e170aa29bb984ad26a9b782ee493c7def30a1fe6
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Matching the changes from WICG/file-system-access#177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414 Reviewed-by: Trent Apted <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Marijn Kruisselbrink <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#790486} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 886077da870a49b4356c44a46f4ea36111a25cd8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #158, fixes #127, and fixes #47.
Preview | Diff