Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should text and image have different entryType #4

Closed
npm1 opened this issue May 22, 2019 · 3 comments
Closed

Should text and image have different entryType #4

npm1 opened this issue May 22, 2019 · 3 comments

Comments

@npm1
Copy link
Collaborator

npm1 commented May 22, 2019

From the TAG review, worth thinking which option is better:

  • A single entryType 'element'.
  • Two entryType values: 'image' and 'text'.
@tdresser
Copy link
Collaborator

We should clearly indicate image vs text somehow.

If we go with image & text, I think:

  • first-paint
  • first-contentful-paint
  • image-paint
  • text-paint

is probably the clearest way to name things?

@npm1
Copy link
Collaborator Author

npm1 commented May 23, 2019

"first-paint" and "first-contentful-paint" are the name values, the entryType values are "paint". So under that reasoning, we should do:

  • Keep entryType as "element"
  • Set the name to something differentiating image and text. Right now, name is used for images as the URL (and for text, as some characters). But this information could be moved to a different attribute.

@npm1
Copy link
Collaborator Author

npm1 commented Aug 14, 2019

This is done.

@npm1 npm1 closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants