Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume transient activation #91

Closed
marcoscaceres opened this issue Mar 11, 2024 · 3 comments · Fixed by #129
Closed

Consume transient activation #91

marcoscaceres opened this issue Mar 11, 2024 · 3 comments · Fixed by #129
Labels

Comments

@marcoscaceres
Copy link
Collaborator

We should probably require to consume transient activation to call identity.get(), as it shows UI.

Plus it would be otherwise annoying if sites could just pop up this dialog.

@RByers
Copy link
Member

RByers commented May 1, 2024

Agreed. Customers may have activation-less use cases (eg. click a button on one page that redirects to a different page where asking again would feel redundant). But I think we should start by requiring a tap/click and relax this only if there's a compelling use case.

Here's the corresponding issue tracking this in the chromium implementation.

@samuelgoto
Copy link
Collaborator

LGTM++

@marcoscaceres
Copy link
Collaborator Author

marcoscaceres commented Jun 21, 2024

I think we want "fully active descendant of a top-level traversable with user attention"... it covers focus etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants