revisions to insertRule and deleteRule have algorithmic definitions that don't quite work

[dbaron]

The revisions to insertRule and deleteRule in https://wicg.github.io/construct-stylesheets/index.html#modifying-constructed-stylesheets have a few problems:

• they use a rule variable that isn't defined (and fixing this probably requires inserting new bits into the middle of the existing algorithm)
• insertRule takes a different number of arguments as the original
• they use different argument names from the original

[dbaron]

(I got here from w3ctag/design-reviews#308.)

[rakina]

Ooh, yeah. And deleteRule shouldn't have the thing about @imports as well. I don't really understand what you meant by " (and fixing this probably requires inserting new bits into the middle of the existing algorithm)"? Since it's an argument to the function, can't we just reference it?

[dbaron]

The thing that's an argument to the function is just a string of text, so the thing that parses it has to come before a test of whether it's an @import rule.