Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace(text) leaves the disallow modification flag set forever if an @import fails to load #65

Closed
dbaron opened this issue Dec 11, 2018 · 1 comment · Fixed by #69
Closed

replace(text) leaves the disallow modification flag set forever if an @import fails to load #65

dbaron opened this issue Dec 11, 2018 · 1 comment · Fixed by #69

Comments

@dbaron
Copy link
Contributor

dbaron commented Dec 11, 2018

The algorithm for replace(text) appears to leave the disallow modification flag set forever in the first part of step 7, where an @import fails to load. It seems like that branch should also clear the disallow modification flag.

(I got here from w3ctag/design-reviews#308.)
@dbaron
Copy link
Contributor Author

dbaron commented Dec 11, 2018

(And it should probably also clear out the style sheet in some way, I'd think.)

@rakina rakina mentioned this issue Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify loading stuff and disallow multiple document usage for now WICG/construct-stylesheets
1 participant
@dbaron