Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why have createEmptyCSSStyleSheet()? #43

Closed
domenic opened this issue Oct 23, 2018 · 1 comment
Closed

Why have createEmptyCSSStyleSheet()? #43

domenic opened this issue Oct 23, 2018 · 1 comment

Comments

@domenic
Copy link
Contributor

domenic commented Oct 23, 2018

Seems nicer to just have one sync constructor, createCSSStyleSheetSync(''). Maybe even make the string optional so you don't need to pass an empty string. (Although I guess passing nothing will be equivalent to passing 'undefined' which will be treated as a no-op ^_^.)

@tabatkins
Copy link
Contributor

It's a spandrel from before when we couldn't make a sync constructor. There's no need to have it anymore.

(And passing nothing can work, we just need to give the argument a default value in IDL. ^_^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants