Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest new wording for section on exception safety #24

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Nov 5, 2023

  • Describes the gamut of exception safety properties
  • Introduces the concept of "intuitive exception safety" for sort algorithms, and explains why it is relevant
  • Explains why not following intuitive exception safety may indirectly cause UB.

@Voultapher
Copy link
Owner

Thanks for creating the PR, I appreciate your help in improving the clarity of the text. Overall there a many good ideas in there, at the same time there are many small things, from using words like we and natural, to grammar things, concepts, language and tone, I have a bunch of suggestions that essentially end up in rewriting the thing, so that's what I did and pushed your branch with a new commit that can be inspected in isolation. Feel free to comment and or update it further.

@dureuill
Copy link
Contributor Author

dureuill commented Nov 6, 2023

Sure your rewrite looks great to me, thanks for your time and patience 🙂

@Voultapher Voultapher merged commit e01321c into Voultapher:main Nov 6, 2023
3 checks passed
@dureuill dureuill deleted the exception-safety branch November 7, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants