Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the comparison to Ourouboros in the README #40

Closed
Shnatsel opened this issue Jun 12, 2023 · 1 comment
Closed

Update the comparison to Ourouboros in the README #40

Shnatsel opened this issue Jun 12, 2023 · 1 comment

Comments

@Shnatsel
Copy link

Ourouboros has a fundamental soundness problem acknowledged by the author, and the author recommends using self_cell in place of ourouboros.

someguynamedjosh/ouroboros#88
@Voultapher
Copy link
Owner

Thanks for the heads-up, I created a PR #41 that changes that section. Please let me know if this fixes this issue. Also I'm glad that I didn't assume 'static lifetime replacement is a valid way to store the value.

@Shnatsel Shnatsel mentioned this issue Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shnatsel @Voultapher