Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphs are broken in Safari #950

Open
filliph opened this issue Mar 7, 2023 · 4 comments
Open

Graphs are broken in Safari #950

filliph opened this issue Mar 7, 2023 · 4 comments

Comments

@filliph
Copy link

filliph commented Mar 7, 2023

image

If you don't have access to a Mac to test, I can have a crack at it if you point me in the direction where to look, as I have some experience with React. I'd also need to know whether there are any .env files I'd need or anything else needed to get a dev instance of the app running 🙂

@filliph
Copy link
Author

filliph commented Mar 7, 2023

The label issue can be resolved by removing position: "relative", top: 2 from https://github.com/Voulk/QuestionablyEpic/blob/master/src/General/Modules/TrinketAnalysis/Charts/VerticalChart.js#L89, which also fixes an alignment issue with the labels in Chrome:

image

@filliph
Copy link
Author

filliph commented Mar 7, 2023

As it turns out, the label issue is the only actionable issue; recharts is applying some very dumb scaling when using sidebar tabs (this behaviour can probably also be seen in MS Edge and any other browser that supports sidebar tabs) where it scales down the vertical size of the bars as well.

This explains why the bars look smaller in Safari compared to Chrome.

I don't know if that behaviour can be changed in the recharts plugin.

@filliph
Copy link
Author

filliph commented May 24, 2024

@Voulk bump, this is still an issue as of today and the fix posted in #950 (comment) is still valid.

@Voulk
Copy link
Owner

Voulk commented Aug 30, 2024

Thanks, I've put a fix through in the next version. Let me know if that fixes it since I don't have a good Safari test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants