Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shopping cart icon & animations according to design #31

Merged
merged 27 commits into from
May 3, 2021
Merged

Add shopping cart icon & animations according to design #31

merged 27 commits into from
May 3, 2021

Conversation

siimha
Copy link
Contributor

@siimha siimha commented Apr 15, 2021 •
edited
Loading

Lisatud ostukorvi nupu popover ja muudetud nupu paigutust mobiilses menüüs vastavalt disainile:

Close #28

@siimha siimha added the enhancement New feature or request label Apr 15, 2021
@siimha siimha self-assigned this Apr 15, 2021
@siimha siimha requested review from robertpih and tanelj April 16, 2021 13:19
@robertpih
Copy link
Contributor

Kas lehel olevas (onsite) ostukorvis peaks koguseid muutes popover nähtaval olema?
Lisaks on kaduma läinud backdrop-filter stiil.

Screen.Recording.2021-04-19.at.12.41.59.mov

@tanelj
Copy link
Member

tanelj commented Apr 20, 2021

Kas lehel olevas (onsite) ostukorvis peaks koguseid muutes popover nähtaval olema?

Ei. "Veiw cart" badge peaks ilmuma vaid ostunupul toote ostukorvi lisamisel (voog:shoppingcart:addproduct).

Mõtteks: Küsimus disaini kohalt, mida arutada - pika tootenime korral peaks äkki tootenime ellipsiga lühendama teatud märgipikkusest alates.

@siimha
Copy link
Contributor Author

siimha commented Apr 20, 2021

Mõtteks: Küsimus disaini kohalt, mida arutada - pika tootenime korral peaks äkki tootenime ellipsiga lühendama teatud märgipikkusest alates.

Küsin stefanilt üle.

tanelj
tanelj requested changes Apr 21, 2021
View reviewed changes
manifest.json Outdated
@@ -1,6 +1,6 @@
{
"description": "Modular layout",
"name": "Nuuk",
"description": "New design",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifestiga on miskit viltu läinud.

Disaini "Name" ja description väljad on muutunud. Product layout on saanud defaultiks (page_default), sama front page'iga jne.

tanelj
tanelj reviewed Apr 21, 2021
View reviewed changes
sources/components/custom-styles/template-cs-style-rules.scss Outdated
@@ -305,7 +305,7 @@ body {
}
}

.edy-ecommerce-shopping-cart-button:hover {
.edy-ecommerce-shopping-cart_btn:hover {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kas siin on liiga hoogsalt saanud asendada?

EI näe, et edy-ecommerce-shopping-cart_btn kusagil kasutusel oleks. Küll aga genereerib ostukorvis skript edy-ecommerce-shopping-cart-button klassi.

@siimha siimha requested a review from tanelj April 29, 2021 05:59
tanelj
tanelj requested changes Apr 29, 2021
View reviewed changes
Copy link
Member

@tanelj tanelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toimib küll kenasti ja ootuspäraselt, kuid küsitavus on ikooni kuvamises (peidetult, kuid ruumi võtvalt) siis, kui toodet pole korvis või pood pole aktiveeritud.

components/header-fixed.tpl
@@ -43,7 +43,11 @@
<div class="js-prevent-sideclick">{%- include "search-btn" -%}</div>
{%- endif -%}
</div>
<div class="cart_btn-container"></div>
<div class="cart_btn">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See div on jäänud sulgemata.

manifest.json Outdated
@@ -37,7 +37,7 @@
"content_type": "blog",
"component": false,
"file": "layouts/blog___news.tpl",
"layout_name": "blog",
"layout_name": "blog___news",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"layout_name" võiks jääda "blog"

components/header-fixed.tpl
@@ -43,7 +43,11 @@
<div class="js-prevent-sideclick">{%- include "search-btn" -%}</div>
{%- endif -%}
</div>
<div class="cart_btn-container"></div>
<div class="cart_btn">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cart_btn div'il hoverdades on ostukorvi ikoon näha ka siis, kui ostukorvis ei ole ühtegi elementi, kuid ka siis, kui saidil on poe funktsionaalus välja lülitatud (JS tasemel puudub Voog ja Voog.ShoppingCart objekt=

@siimha siimha requested a review from tanelj April 29, 2021 14:01
tanelj
tanelj requested changes Apr 29, 2021
View reviewed changes
Copy link
Member

@tanelj tanelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ostukorvi osa töötab nüüd kenasti!

Kuid tekkis regressioon menüü "Side — opens on click" korral, kus saidi nimi oli enne (masteris) keskel, nüüd on vasakul (ja tühja sisu korral väike).

Enne
Screenshot 2021-04-29 at 18 00 46

Nüüd
Screenshot 2021-04-29 at 18 10 25

@siimha siimha requested a review from tanelj April 30, 2021 08:07
@tanelj tanelj merged commit 15697d6 into master May 3, 2021
@tanelj tanelj deleted the 28_shopping_cart_animations branch May 3, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertpih robertpih robertpih approved these changes

@tanelj tanelj tanelj approved these changes

Assignees

@siimha siimha

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shopping cart icon & animations according to design
3 participants
@siimha @robertpih @tanelj