Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify v1 - Deprecations when getting Verification::getRequest() #434

Open
kissifrot opened this issue Aug 29, 2023 · 3 comments
Open

Verify v1 - Deprecations when getting Verification::getRequest() #434

kissifrot opened this issue Aug 29, 2023 · 3 comments
Assignees
Labels
bug v5 Version 5 features/fixes

Comments

@kissifrot
Copy link

We are getting deprecation messages every time we call verify()

Expected Behavior

When using verify()->check($verificationCode, $code), we should not get deprecation warnings

Current Behavior

When using verify()->check($verificationCode, $code), we are getting lots of deprecation messages User Deprecated: Vonage\Verify\Verification::getRequest() is deprecated. Please get the APIResource from the appropriate client to get this information

Possible Solution

Steps to Reproduce (for bugs)

  1. Just use verify()->check($verificationCode, $code) (we use it in symfony context)

Context

Our sentries issues are filled with those messages 😅

Your Environment

  • Version used: 4.3.1
  • Environment name and version (e.g. PHP 7.2 on nginx 1.19.1): PHP 8.2 on nginx
  • Operating System and version: Ubuntu 20.04 LTS
@SecondeJK SecondeJK self-assigned this Sep 18, 2023
@SecondeJK SecondeJK added the bug label Sep 18, 2023
@SecondeJK
Copy link
Contributor

Thanks for reporting this.
I'll need to do a bit of investigation, as removing the deprecations (we had a circular warning dependency problem here) might be a backward breaking change, which means it'll have to wait until 5.0

@SecondeJK SecondeJK added the v5 Version 5 features/fixes label Jan 25, 2024
@tairoroberto
Copy link

tairoroberto commented Jul 15, 2024

This still happening.


Vonage\Verify\Verification::getResponse() is deprecated. Please get the APIResource from the appropriate client to get this information in /var/www/html/code/vendor/vonage/client-core/src/Entity/Psr7Trait.php on line 103

Vonage\Verify\Verification::setResponse() is deprecated and will be removed in /var/www/html/code/vendor/vonage/client-core/src/Entity/Psr7Trait.php on line 45

Using Vonage\Verify\Verification for starting a verification is deprecated, please use Vonage\Verify\Request instead in /var/www/html/code/vendor/vonage/client-core/src/Verify/Verification.php on line 83

Creation of dynamic property Vonage\Verify\Verification::$data is deprecated in /var/www/html/code/vendor/vonage/client-core/src/Entity/Psr7Trait.php on line 66

@SecondeJK
Copy link
Contributor

This will unfortunately keep happening until version 5 comes out, when deprecations will be actually removed and the internals fixed. I can't change the internal signatures until a major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug v5 Version 5 features/fixes
Projects
None yet
Development

No branches or pull requests

3 participants