Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small visual bonus game sprite bug in SA-1 1.40 #34

Open
Anas13303 opened this issue Feb 13, 2023 · 2 comments
Open

Small visual bonus game sprite bug in SA-1 1.40 #34

Anas13303 opened this issue Feb 13, 2023 · 2 comments

Comments

@Anas13303
Copy link

Anas13303 commented Feb 13, 2023

If the bonus game sprite (sprite 82) is used in a level with sprite memory setting 0x08, a small visual bug will occur here:

uw029

Here, there is a stray bonus game block that infinitely wraps around the screen horizontally. I remember encountering this bug in SA-1 1.32 as well but never thought much about it. Why would anyone set the sprite memory to 0x08 here? Well, maybe it is because people would like to extend the bonus game level and add more enemies to pose some challenge. It would be nice if this bug is fixed. Thanks!

@kkevinm
Copy link
Contributor

kkevinm commented Mar 4, 2023

This seems to be caused by the sprite spawning the 9 boxes not being erased afterwards, which then gets handled like one of the boxes. This doesn't happen in other sprite headers because the spawner actually gets replaced with one of the 9 boxes (since its sprite slot is 9, and it spawns the boxes in slots 1-9), but using sprite header 8 makes it spawn in slot 19 which doesn't get replaced.
I made a simple patch here which fixes the issue.

@Anas13303
Copy link
Author

Although the patch doesn't fix the whole bonus game roulette itself wrapping around every screen (which I should've specified myself), it does fix that stray bonus game box wrapping across the screen horizontally. Thanks for the fix! I will see what I can do about that other bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants