Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Cleanup of stac builder code #53

Open
12 tasks
VictorVerhaert opened this issue Nov 28, 2024 · 0 comments
Open
12 tasks

[EPIC] Cleanup of stac builder code #53

VictorVerhaert opened this issue Nov 28, 2024 · 0 comments

Comments

@VictorVerhaert
Copy link
Collaborator

VictorVerhaert commented Nov 28, 2024

This issue serves as an overview of changes to make to the stac builder to clean up the code.
It's goal is to make the builder easier to understand, debug and expand.

  • use pyproject.toml as only dependency source to prevent inconsistent environments (terracatalogue might need a seperate init for this)
  • make terracatalogue depedency optional
  • Use the AssetMetadata as the generic interface for all the data that needs to be extracted out of sources. After this al generic behaviour should be able to be implemented by using custom callbacks. This allows for a lot of code to be removed improving readability.
  • [optional/discussion needed] move all the arguments to the config file so one workflow could in theory be used for all collections that do not need custom item postprocessors. (This would allow for easily rebuilding all collections should a bug be found in the builder)
  • remove backup code for saving to geoparquet and dataframes as this is not being used for debugging and complicates the code
  • cleanup TODO's (currently 95 in total) -> either create an issue for it and link it in the code, directly fix it or deem the todo unnecessary
  • remove docker functionality (was this ever used?)
  • remove makefile funtionality -> setting up environments should not be the responsibility of the stac builder and should be easy with the pyproject.toml, the makefiles for building collections are not being used or up to date
  • running extra linting tools on the source code (similar to the openeo-python-client)
  • Update the documentation (most of it is outdated)
  • Update the template for new collections -> keep this up to date with new collections being build
  • better determine collection metadata from items (item_assets, summaries)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant