Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Totally broken. #43

Closed
bennetgallein opened this issue Dec 27, 2018 · 1 comment
Closed

Totally broken. #43

bennetgallein opened this issue Dec 27, 2018 · 1 comment

Comments

@bennetgallein
Copy link

Hi,
I freshly required the library over composer and tried implementing it into my existing code. After a first Test run, I had 2 Unknown Variables in the source of this library... Like how could this happen? I'm just using it to update stuff?? You cannot tell me that nobody else ran into this issue.

Nevertheless, I will build on this foundation and created a fork where I'll be refactor the code and fix the above mentioned errors.

@thelfensdrfer
Copy link
Member

thelfensdrfer commented Dec 28, 2018

This is literally the first paragraph in the readme:

I created it as a proof of concept and don't know if it is used somewhere. So please use this library with caution because it can potentially make your users software nonfunctional if something goes wrong.

But thanks for mentioning the issues. If you had mentioned the line numbers or errors, it would be even better, just for the next time.

Edit:

And to address your remarks:

  • Like how could this happen: Programming errors
  • I'm just using it to update stuff: For what else would you use this library?
  • You cannot tell me that nobody else ran into this issue: Do you think i silently deleted the other issues 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants