Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent None accumulation #268

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Prevent None accumulation #268

merged 1 commit into from
Nov 17, 2022

Conversation

thibo73800
Copy link
Contributor

General description of your pull request with the list of new features and/or bugs.

  • New feature 1 :
    When manipulating aug tensor, _saved_names can accumulate None values which could prevent proper concatenation. Note that this might not be an issue once we have a good merging policy of different properties within aug tensors.

This pull request includes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Data-Iab Data-Iab self-requested a review November 17, 2022 14:12
@thibo73800 thibo73800 linked an issue Nov 17, 2022 that may be closed by this pull request
_saved_names can accumulate None within tuple #267
Open
@Data-Iab Data-Iab merged commit f16022e into alobugdays Nov 17, 2022
@thibo73800 thibo73800 deleted the 267-saved-names-none branch November 17, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Data-Iab Data-Iab Data-Iab approved these changes

Assignees
No one assigned
Labels
alobugdays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_saved_names can accumulate None within tuple
2 participants
@thibo73800 @Data-Iab