Support pytorch1.13 #264
Merged
Support pytorch1.13 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2022 13:45
…s into support-pytorch1-13
|
Going back to DRAFT, some issue with some training pipeline |
|
@Data-Iab We can try to merge it. |
Data-Iab
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General description of your pull request with the list of new features and/or bugs.
__torch_function__was about to not be supported anymore. Switching toclassmethodwas required. The current implementation seem to still be compatible with pytorch 1.10. Note that this change is touching to the most important/breakable part of the aug tensor pipeline.Open discussion: Should be update the doc to make pytorch 1.13 the default ? I think not before to check for pytorch lightning support.
By the way: c8ed7f6b1cdfeeec369447517af7321349df1e25
This pull request includes