Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--skip-larger not working #1677

Closed
BitsOfBinary opened this issue Apr 5, 2022 · 4 comments
Closed

--skip-larger not working #1677

BitsOfBinary opened this issue Apr 5, 2022 · 4 comments

Comments

@BitsOfBinary
Copy link
Contributor

For YARA v4.2.0, I can't get the --skip-larger flag to work.

I can't see what the cause of this is, but it doesn't seem to take into account the size parameter at all from the command line.

@BitsOfBinary
Copy link
Contributor Author

This was tested on Windows 10 for context

@plusvic
Copy link
Member

plusvic commented Apr 6, 2022

Actually the --skip-larger feature was not implemented in Windows at all. I've done it in #1678. Right now I don't have a Windows machine around for testing, could check it works? Here you have a compiled yara binary with the fix: yara-fix_1677-1903-win64.zip

@BitsOfBinary
Copy link
Contributor Author

Thank you @plusvic! Just tested the fix locally on my Windows machine, and can see it is skipping files. Looks like your fix does the trick 👍

@plusvic
Copy link
Member

plusvic commented Apr 6, 2022

Great!

@plusvic plusvic closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants