Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the --source command line option for the package sub-command #3257

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Nov 4, 2024

  • the --source command line option alias (which makes the package sub-command produce source JARs) is getting deprecated in preparation for Misc improvements in compiler options handling #3253.
  • it will likely be removed in Scala CLI v1.6.0, where --source will be treated as a compiler option instead.
  • the recommended syntax would now be --src.
scala-cli-jvm --power package --source .                       
# [warn] The --source option alias has been deprecated and may be removed in a future version.
(...)

@Gedochao Gedochao force-pushed the maintenance/deprecate-source branch from 4460f66 to 404763c Compare November 5, 2024 11:17
@Gedochao Gedochao requested a review from tgodzik November 5, 2024 11:18
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 23f6949 into VirtusLab:main Nov 5, 2024
76 of 78 checks passed
@Gedochao Gedochao deleted the maintenance/deprecate-source branch November 5, 2024 16:03
@SethTisue
Copy link
Contributor

SethTisue commented Nov 12, 2024

I'm sorry, I know this feedback is coming too late, but could a more different name than --src be found? --src and -source still seem awfully confusable with each other, especially when spoken out loud.

@SethTisue
Copy link
Contributor

Maybe --with-sources?

@tgodzik
Copy link
Member

tgodzik commented Nov 14, 2024

--src already existed before and I agree it's easy to confuse. @Gedochao maybe we should deprecate both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants