Add deprecation reporting mechanism for using directives #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
changed the title
MaciejG604
changed the title
MaciejG604
force-pushed
the
deprecate-latest-toolkit
branch
3 times, most recently
from
caedc81 to
f2cad92
Compare
MaciejG604
force-pushed
the
deprecate-latest-toolkit
branch
5 times, most recently
from
5a22278 to
6539323
Compare
MaciejG604
force-pushed
the
deprecate-latest-toolkit
branch
4 times, most recently
from
4c7d609 to
98d8c1e
Compare
Gedochao
reviewed
Dec 20, 2023
modules/build/src/main/scala/scala/build/internal/util/WarningMessages.scala
Outdated
Show resolved
Hide resolved
modules/build/src/main/scala/scala/build/preprocessing/DeprecatedDirectives.scala
Outdated
Show resolved
Hide resolved
modules/build/src/main/scala/scala/build/preprocessing/DeprecatedDirectives.scala
Outdated
Show resolved
Hide resolved
modules/build/src/main/scala/scala/build/preprocessing/ExtractedDirectives.scala
Show resolved
Hide resolved
modules/build/src/main/scala/scala/build/preprocessing/ExtractedDirectives.scala
Outdated
Show resolved
Hide resolved
Gedochao
reviewed
Dec 20, 2023
MaciejG604
force-pushed
the
deprecate-latest-toolkit
branch
from
98d8c1e to
cb68335
Compare
MaciejG604
force-pushed
the
deprecate-latest-toolkit
branch
2 times, most recently
from
d6ced3c to
53a9765
Compare
Test toolkit default and warnings for latest Correctly treat both aliases for typelevel toolkit Add an error about Scala 2.12 not supported for toolkits Update tests for default of known toolkits Test actionable diagnostics on deprecated directives for BSP Update FixTests.scala
MaciejG604
force-pushed
the
deprecate-latest-toolkit
branch
from
53a9765 to
52692f7
Compare
Gedochao
approved these changes
Dec 21, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2473 and #2426
After merge:
We'll need to make changes to the docs of known toolkits to use 'default'