Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable COURSIER_BIN_DIR override & run tests on M1 #382

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

Gedochao
Copy link

@Gedochao Gedochao commented Nov 20, 2023

  • tests will now also be run on macOS-m1
  • it is now advised to set COURSIER_BIN_DIRto ${{ github.workspace }}/cs/bin for self-hosted runners (like our M1)

@Gedochao Gedochao force-pushed the maintenance/run-tests-on-m1 branch from 7a7b520 to dd2ff6f Compare November 20, 2023 13:28
@Gedochao Gedochao changed the title Run tests on M1 Enable COURSIER_BIN_DIR override & run tests on M1 Nov 20, 2023
@Gedochao Gedochao marked this pull request as ready for review November 20, 2023 13:31
Copy link

@MaciejG604 MaciejG604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit a54713e into VirtusLab:main Nov 20, 2023
4 checks passed
@Gedochao Gedochao deleted the maintenance/run-tests-on-m1 branch November 20, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants