Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prompt during Build #157

Open
scottprahl opened this issue Aug 2, 2024 · 1 comment
Open

Update prompt during Build #157

scottprahl opened this issue Aug 2, 2024 · 1 comment

Comments

@scottprahl
Copy link

Describe the bug
The build stops and asks

Press Enter to exit

This is ambiguous. I thought it the build would exit without completing. A slightly less ambiguous prompt might be

Build Complete. Press Enter to continue.

Application (MCCL, MATLAB or VTS code):

This seems to be in all the Build files. The Read-Host -Prompt lines are something like

Read-Host -Prompt "Press Enter to exit MATLAB release process"

To Reproduce

./BuildTestCore.ps1
./BuildTestRelease.ps1
./BuildTestReleaseMATLAB.ps1
./BuildTestReleaseMCCL.ps1
./BuildTestReleaseScripting.ps1

Expected behavior
Less ambiguous prompt

Additional context
Obviously not critical

@lmalenfant
Copy link
Member

Hi Scott,

This is a great suggestion, these scripts (that were originally batch files) were written to create the release versions of the software and not specifically intended for end users. Seeing that you are using these scripts, we can definitely make them less ambiguous for an external user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants