Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

JSLint/ESlint errors inside assets/js files #39

Open
brgrz opened this issue Aug 11, 2018 · 4 comments
Open

JSLint/ESlint errors inside assets/js files #39

brgrz opened this issue Aug 11, 2018 · 4 comments
Assignees
@Tilesto

Comments

@brgrz
Copy link

brgrz commented Aug 11, 2018

The angular app that gets build using gulp contains lots of lint errors (not only warnings). I actually cannot rebuild it again (gulp fails due to jslint issues).

Do you plan to fix them or will you accept a pull request if we fix them?
@brgrz brgrz changed the title Eslint errors inside JS files JSLint/ESlint errors inside JS files Aug 11, 2018
@brgrz brgrz changed the title JSLint/ESlint errors inside JS files JSLint/ESlint errors inside assets/js files Aug 11, 2018
@Woland2k
Copy link
Contributor

@brgrz submit the pull request and we'll review

@asvishnyakov
Copy link
Contributor

asvishnyakov commented Aug 12, 2018 •
edited
Loading

@brgrz I believe build shouldn't fail because of lint errors. May you attach gulp output (error log) to issue?

@brgrz
Copy link
Author

brgrz commented Aug 13, 2018

Here is the gulp output
https://gist.github.com/brgrz/ee14bac3f04f05895de8810077b9cf0d

@tatarincev tatarincev added this to the Operations milestone Aug 17, 2018
@brgrz
Copy link
Author

brgrz commented Dec 16, 2018

There's a PR for this now #57

@t13ka t13ka removed this from the Operations milestone Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tilesto Tilesto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@brgrz @Woland2k @asvishnyakov @tatarincev @t13ka @Tilesto