Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrailingCommaMultiLineRule Issue with Empty Arrays #325

Closed
conradweberling opened this issue Nov 6, 2024 · 2 comments · Fixed by #326
Closed

TrailingCommaMultiLineRule Issue with Empty Arrays #325

conradweberling opened this issue Nov 6, 2024 · 2 comments · Fixed by #326

Comments

@conradweberling
Copy link

Rule(s) related to or rule(s) missing

TrailingCommaMultiLineRule

Expected behavior

{% set allowed = [
] %}

Actual behavior

{% set allowed = [,
] %}

Yesterday the rule TrailingCommaMultiLineRule was activated again by default, but causes the php runtime error Unexpected token "punctuation" of value "," as soon there are empty arrays in the code. See #320.

@VincentLanglet
Copy link
Owner

Thanks for the report @conradweberling, does #326 fix all the issues or am I missing some cases ?

@conradweberling
Copy link
Author

@VincentLanglet Looks good - It works now for my codebase! Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants