Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The screenSize property is not required on the SystemHeader storybook #172

Open
ydg opened this issue Jun 2, 2023 · 5 comments
Open

The screenSize property is not required on the SystemHeader storybook #172

ydg opened this issue Jun 2, 2023 · 5 comments
Labels
enhancement New feature or request good first issue ⛺ Good for newcomers

Comments

@ydg
Copy link
Contributor

ydg commented Jun 2, 2023

The 'Viewport' option of the 'Canvas' view is made for that
image

@OlivierAlbertini
Copy link
Member

That's true ! Thanks !

@OlivierAlbertini OlivierAlbertini added enhancement New feature or request good first issue ⛺ Good for newcomers labels Jun 2, 2023
@OlivierAlbertini
Copy link
Member

Hi @ydg

Do you have the bandwidth to do it ? I can assign you if so. Let me know !

@MaudeLaflamme
Copy link
Collaborator

MaudeLaflamme commented Jun 12, 2023

@OlivierAlbertini
Salut @ydg !
I added the screenSize property in order to showcase the different buttons' configuration (depending on the type of screen it's being viewed on) without having to add script to the storybook example. The reason being that I haven't managed to find how to insert scripts within storybook examples. So with the screenSize property, I can directly add my conditional template inside ng-template tags IN the storybook example template, therefore allowing future users of the SystemHeader component to have the complete template in order to have a responsive component.

Hope this is clear, let me know if you have any questions (or suggestions) :)

@OlivierAlbertini
Copy link
Member

@OlivierAlbertini Salut @ydg ! I added the screenSize property in order to showcase the different buttons' configuration (depending on the type of screen it's being viewed on) without having to add script to the storybook example. The reason being that I haven't managed to find how to insert scripts within storybook examples. So with the screenSize property, I can directly add my conditional template inside ng-template tags IN the storybook example template, therefore allowing future users of the SystemHeader component to have the complete template in order to have a responsive component.

Hope this is clear, let me know if you have any questions (or suggestions) :)

Perhaps it's just linking the functionality to the viewport. When we change the viewport, it should pass the viewport value to the component like https://varya.me/blog/stories-with-different-viewports/

@ydg
Copy link
Contributor Author

ydg commented Jun 14, 2023

Yes, what I meant is if the end user wants to see how the component behaves in different viewport he should do it in the Viewport view of the Canvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue ⛺ Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants