Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of operator docs (#638) #724

Merged
merged 38 commits into from
Sep 29, 2023
Merged

New version of operator docs (#638) #724

merged 38 commits into from
Sep 29, 2023

Conversation

Amper
Copy link
Contributor

@Amper Amper commented Aug 11, 2023 •
edited
Loading

issue #638

@Amper Amper added the documentation Improvements or additions to documentation label Aug 11, 2023
f41gh7
f41gh7 previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amper Amper marked this pull request as ready for review September 25, 2023 07:36
@Amper Amper changed the title WIP: New version of operator docs (#638) New version of operator docs (#638) Sep 25, 2023
@Amper Amper self-assigned this Sep 25, 2023
@Amper Amper requested a review from zekker6 September 25, 2023 10:39
tenmozes
tenmozes reviewed Sep 25, 2023
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
@Haleygo Haleygo mentioned this pull request Sep 25, 2023
Closed
@Amper Amper requested a review from k1rk September 26, 2023 16:01
@Amper
Merge branch 'master' into issue-638
ffef1ac 
# Conflicts:
#	docs/CHANGELOG.md
Haleygo
Haleygo previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Amper
Merge branch 'master' into issue-638
b89ad9d 
# Conflicts:
#	docs/CHANGELOG.md
Haleygo
Haleygo previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zekker6
zekker6 reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@zekker6 zekker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see a few comments

docs/resources/vmalertmanagerconfig.md Outdated Show resolved Hide resolved
docs/resources/vmalertmanagerconfig.md Show resolved Hide resolved
docs/resources/vmauth.md Outdated Show resolved Hide resolved
docs/auth.md Show resolved Hide resolved
docs/resources/vmalert.md Outdated Show resolved Hide resolved
@Amper Amper requested a review from zekker6 September 29, 2023 09:41
@Amper Amper merged commit c6c318b into master Sep 29, 2023
3 checks passed
@Amper Amper deleted the issue-638 branch September 29, 2023 09:55
@hagen1778 hagen1778 mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenmozes tenmozes tenmozes left review comments

@zekker6 zekker6 zekker6 approved these changes

@Haleygo Haleygo Haleygo left review comments

@f41gh7 f41gh7 f41gh7 left review comments

@hagen1778 hagen1778 Awaiting requested review from hagen1778

@k1rk k1rk Awaiting requested review from k1rk

Assignees

@Amper Amper

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Amper @zekker6 @tenmozes @f41gh7 @Haleygo