-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmalert.spec support host_aliases #1099
Labels
enhancement
New feature or request
waiting for release
The change was merged to upstream, but wasn't released yet.
Comments
I'm moving this to operator repo since it's about vmalert CR. |
Looks like HostAliases setting is also missing at cluster components. |
f41gh7
added a commit
that referenced
this issue
Sep 18, 2024
It was added to the all other CRD resources except VMAlert. This commit fixes this bug and adds `hostAliases` to the `vmalert.spec`. Related issue: #1099 Signed-off-by: f41gh7 <[email protected]>
f41gh7
added a commit
that referenced
this issue
Sep 19, 2024
It was added to the all other CRD resources except VMAlert. This commit fixes this bug and adds `hostAliases` to the `vmalert.spec`. Related issue: #1099 Signed-off-by: f41gh7 <[email protected]>
f41gh7
added
the
waiting for release
The change was merged to upstream, but wasn't released yet.
label
Sep 19, 2024
Will be fixed at next release. Operator will support both spec naming |
Inconsistency was fixed at v0.48.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
waiting for release
The change was merged to upstream, but wasn't released yet.
Is your feature request related to a problem? Please describe
No response
Describe the solution you'd like
I think vmalert.spec can support host_aliases, like vmagent crd.
Describe alternatives you've considered
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: