k8s-stack: added alertmanager datasource, vlogs resource and vlogs datasource; vlogs: added dashboard #1593
Conversation
AndrewChubatiuk
requested review from
zekker6,
Haleygo and
f41gh7
as code owners
github-actions
bot
added
k8s-stack
| @@ -57,6 +57,8 @@ defaultDashboards: | |||
| allowCrossNamespaceImport: false | |||
| # -- Create dashboards as ConfigMap despite dependency it requires is not installed | |||
| dashboards: | |||
| victorialogs: | |||
There was a problem hiding this comment.
Since VM k8s-stack chart doesn't install victorialogs, I don't think we should include victorialogs dashboard here.
There was a problem hiding this comment.
added vlogs to k8s-stack chart
There was a problem hiding this comment.
I don't believe we should include victorialogs resources(workload, dashboard or rules) in victoria-metrics-k8s-stack chart:
- it doesn't integrate with other components, like collecting their logs without other configuration.
- I think user would prefer to install log and metrics management components separately, since they're not bundled or related. (Some resources, such as grafana or vm-operator can be shared for sure, but this can be considered additionally, like installing them separately from both VM and VLogs releases.)
I think we could have another new chart for victoriaLogs in the furture, which contains vm-operator, single&cluster version of victoriaLogs, grafana, vmalert&alertmanager and possibly some common optional log collectors.
| @@ -359,3 +359,12 @@ fluent-bit: | |||
|
|
|||
| # -- Add extra specs dynamically to this chart | |||
| extraObjects: [] | |||
|
|
|||
| dashboards: | |||
| # -- Create VictoriaLogs dashboards | |||
There was a problem hiding this comment.
Maybe we should also support creating it as a GrafanaDashboard CR like k8s-stack does, wdyt?
And I think we should disable it by default now, currently it's not clear or convenient to tell users how to get access to dashboard or rule in vlogs chart, since the chart doesn't contain grafana or ruler components.
There was a problem hiding this comment.
added this as well
AndrewChubatiuk
changed the title
fixes #1592
partially resolves #1590