Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] The boot method in a bundle should be empty. - in Bundle/I18nBundle/VictoireI18nBundle.php, line 15 #115

Closed
talbotseb opened this issue Jun 2, 2015 · 0 comments
Milestone

Comments

@talbotseb
Copy link

in Bundle/I18nBundle/VictoireI18nBundle.php, line 15

VictoireI18nBundle has a non-empty boot method, which may slow down Symfony2 application boot.

class VictoireI18nBundle extends Bundle
{
        /**
         * the function add a cache driver to get and track i18n entity
         */
    public function boot()
    {
        $driverChain = $this->container->get('doctrine.orm.entity_manager')->getConfiguration()->getMetadataDriverImpl();
        $proxyDriver = $this->container->get('victoire_i18n.i18n.cache_driver');
        $driverChain->addDriver($proxyDriver, 'Victoire\\Bundle\\I18nBundle');
    }

Posted from SensioLabsInsight

@clekos clekos added this to the I18N milestone Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants