Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DynamicSupervisor and GenServers for Sibyl.Dynamic #8

Open
vereis opened this issue Jul 8, 2022 · 0 comments
Open

Use DynamicSupervisor and GenServers for Sibyl.Dynamic #8

vereis opened this issue Jul 8, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vereis
Copy link
Collaborator

vereis commented Jul 8, 2022

See TODO linked in Sibyl.Dynamic module for more info, but in short:

Right now, dynamic tracing traces all specified functions via one single process. This is fine for simple traces, but unless we distinguish between invocations of specified functions by their PIDs, we risk accidentally starting, nesting, or ending spans prematurely.

We should instead, based on the PID of the incoming dynamic trace, delegate the handling of messages to GenServers under a DynamicSupervisor which can start up if needed.
@vereis vereis added enhancement New feature or request help wanted Extra attention is needed labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vereis