-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate and HTML reports with the coverage report generated/calculated #19
Comments
Could a strategy to tackle this problem be?:
I think this might be an easy and simple way to generate the files we need without involving some big overhead from a framework. EDIT: This commit shows a proof of concept that might be easier than explaining it, and here's a screenshot of the results: |
Hey @mtwichel thanks so much for the contribution! The only downside to the handlebars approach that I can see is the individual file view where developers can drill down to see which line(s) aren't covered will need to be implemented as well. What do you think? |
Wow @mtwichel thank you so much for contributing and helping us! I really appreciate the energy! 💙 I am leaning towards @felangel response at the moment: I would love to try to stay as close as possible to |
Thanks for the replies! This is my first toe-dip into really contributing to open source so I apologize in advance if I don't fully get the conventions or standards. 🙂 To @felangel, I think we could make another template file for the line-by-line coverage detail, then read in the files by the path from lcov-parse and display the coverage in that template. To @jorgecoca,
I'm curious about your motivation for that? I see that using an existing package that already generates the report file would be much easier and faster; however, I don't think the solution I presented is very challenging either. I'm also not convinced the report generated by the existing I'm even curious if a generated report in html is the best solution for a github action? What if we posted a nicely formatted comment on the PR that displays the coverage you attained, as well as lines you missed? That seems even easier than opening a report and clicking through the files that don't have 100%. I couldn't agree more on splitting off this chunk to a separate package though, maybe
That way this action can just consume that API and do whatever it wants with it (comment, artifact the reports, etc), and we could also build a CLI for running the tool locally like #20 discusses. LMK your thoughts |
I'd like to recommend coverde, a CLI written in Dart that allows you to manipulate coverage and is actually much easier to use than |
As a customer of this Github Action, I would love to be able to generate a visual/HTML report with the coverage of my project, so I can easily inspect what's the status of my testing strategy.
As an example, we can see how
genhtml
fromlcov
works:Thank you! 💙
The text was updated successfully, but these errors were encountered: