Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTSLIB env variable is required but not checked #21

Open
jrandall opened this issue Jun 4, 2015 · 0 comments
Open

HTSLIB env variable is required but not checked #21

jrandall opened this issue Jun 4, 2015 · 0 comments

Comments

@jrandall
Copy link

jrandall commented Jun 4, 2015

The FileType class builds a path to the htsfile command by assuming that the HTSLIB env variable is set, but nothing ever checks to make sure it is set (so it doesn't work even if htsfile s in the PATH):

my $htsfile_exe = file($ENV{HTSLIB}, 'bin', 'htsfile');

As a result, we end up getting a lot of "...exists but is the wrong type" messages from StepRole, when the real problem was just that HTSLIB is not set.

I would suggest that VRPipe::FileType::hts should check to make sure that HTSLIB env variable is set and throws an error if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant