email and password autocomplete in Browser mode

[lolgab]

It would be nice if the browser mode could autocomplete the email and password when logging in in Google. It's annoying having to type the password especially for people who use their browser's password manager, since the browser runs in a clean session (as it should).

[cjerdonek]

If you run saml2aws --help, you can see there is a --browser-autofill option:

--browser-autofill

  Configures browser to autofill the username and password. (env: SAML2AWS_BROWSER_AUTOFILL)

[lolgab]

Oh wow, had no idea, that's wonderful, thank you

[lolgab]

It doesn't seem to work though. Maybe Google changed their login page.

[cjerdonek]

It doesn't seem to work though. Maybe Google changed their login page.

Yeah, I'm not surprised. When I looked at the code implementing their auto-fill feature, it seemed to make some pretty strong assumptions about how the login page needs to be structured. The code can be find here (autoFill() function of pkg/provider/browser/browser.go):

saml2aws/pkg/provider/browser/browser.go

Lines 205 to 223 in 953bb29

	var autoFill = func(page playwright.Page, loginDetails *creds.LoginDetails) error {
	passwordField := page.Locator("input[type='password']")
	err := passwordField.WaitFor(playwright.LocatorWaitForOptions{
	State: playwright.WaitForSelectorStateVisible,
	})
	if err != nil {
	return err
	}
	err = passwordField.Fill(loginDetails.Password)
	if err != nil {
	return err
	}
	keyboard := page.Keyboard()
	// move to username field which is above password field
	err = keyboard.Press("Shift+Tab")

Thus, I would keep this issue but retitle it to something like, "Make --browser-autofill feature work with Google's login page."

[cjerdonek]

Btw, the following issue is related to making --auto-fill work with Google's login page: #1295

[lolgab]

Thank you, I will follow that issue then 👍