Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseSplitModeForUniqueDirectory configurability per test #757

Closed
JanKrivanek opened this issue Jan 6, 2023 · 1 comment · Fixed by #760
Closed

UseSplitModeForUniqueDirectory configurability per test #757

JanKrivanek opened this issue Jan 6, 2023 · 1 comment · Fixed by #760
Labels
Milestone

Comments

@JanKrivanek
Copy link
Contributor

Situation

UseSplitModeForUniqueDirectory is currently only a global option - it's not possible to be set per test (via VerifySettings instance)

Problem

The directory snapshot mode is now decision per whole module.
This can be especially problematic in situations where Verify is being used as part of wrapping tooling that wants to set the split mode for usages in it's own scope. Such tooling is then automatically incompatible with standard usage of Verify (due to possible attempt to set global setting after InnerVerifier has already run for unrelated test).

Proposed solution

Add members to VerifySettings to set the nullable flag with the same meaning. The current usage of VerifierSettings.UseUniqueDirectorySplitMode would prefer the local flag if not null.

I'm more than happy to create PR for this if this request is acknowledged and agreed

@JanKrivanek
Copy link
Contributor Author

Perfetto! Thank you Simon! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants