Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Send Page Address Book Issues #903

Open
CaveSpectre11 opened this issue Mar 21, 2021 · 2 comments
Open

[GUI] Send Page Address Book Issues #903

CaveSpectre11 opened this issue Mar 21, 2021 · 2 comments
Assignees
Labels
Component: GUI Primarily related to the display of the user interface Dev Status: Open PR The work for this issue is done, and waiting to be merged. Good First Issue Easy enough that people new can complete.

Comments

@CaveSpectre11
Copy link
Collaborator

Some issues to look into:
Send->Address Book

  • There are 3 columns, the 3rd column appears to be a second copy of the address. Need to look into the code to see if there's an indication of what that column is supposed to be
  • Columns should have titles
  • Right clicking on a Row brings up a menu, but the mouseover makes the selection white on white.
@CaveSpectre11 CaveSpectre11 added Component: GUI Primarily related to the display of the user interface Good First Issue Easy enough that people new can complete. labels Mar 21, 2021
@Rock-N-Troll
Copy link

Rock-N-Troll commented Mar 24, 2021

  1. It looks like address dot is really the shortened version of the address with the ellipsis in the middle (as discovered through copy paste)
    sv1xxxxxxxzg3qltya...h37xxxxxxxxxxxxzzd

  2. The columns do have titles (they display on my screen, but did disappear after resizing on at least 1 occasion) but I think the display on resize or platforms is sometimes not displaying properly:
    Label, Address, Address dot

  3. I suspect this is also related to Display issue

@Rock-N-Troll
Copy link

Rock-N-Troll commented Mar 24, 2021

addresstabelmodel.cpp:

 case Address_dot:
            return rec->address.left(18) + "..." + rec->address.right(18);

Looks like resize is missing on the Address_dot column:
in addressbookpage.cpp -> void AddressBookPage::setModel(AddressTableModel *_model)
I.E. ui->tableView->horizontalHeader()->setSectionResizeMode(AddressTableModel::Address_dot, QHeaderView::ResizeToContents);

@CaveSpectre11 CaveSpectre11 added the Dev Status: Open PR The work for this issue is done, and waiting to be merged. label Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI Primarily related to the display of the user interface Dev Status: Open PR The work for this issue is done, and waiting to be merged. Good First Issue Easy enough that people new can complete.
Projects
None yet
Development

No branches or pull requests

2 participants