Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add option for the close button to completely exit steam #4772

Closed
alemansec opened this issue Dec 21, 2016 · 10 comments
Closed

Comments

@alemansec
Copy link

alemansec commented Dec 21, 2016

Your system information

  • Steam client version:1482214037
  • Distribution (e.g. Ubuntu): Debian GNU/Linux Jessie x86_64 up-to-date
  • Opted into Steam client beta?: [Yes/No] Yes & No (both afected)
  • Have you checked for system updates?: [Yes/No] Yes

Please describe your issue in as much detail as possible:

hitting the window close button (within steam client custom titlebar) DOES NOT CLOSE the steam client application, but MINIMIZES IT INSTEAD

Steps for reproducing this issue:

  1. start the steam client
  2. let it start
  3. hit the close button (the valve custom "X" button on steam client custom titlebar)

expected behaviour

Application clean exit

obtained behaviour

Application MINIMIZES instead of CLOSING

@kisak-valve
Copy link
Member

Hello @alemansec,
Per #1025 (comment), this is the current intended behavior. If you want the window to close, set the STEAM_FRAME_FORCE_CLOSE=1 environment variable.

Closing as a duplicate.

@alemansec
Copy link
Author

STEAM_FRAME_FORCE_CLOSE=1 env var does not fix it :

$ env|grep STEAM
STEAM_FRAME_FORCE_CLOSE=1

$ steam

wait for it ...
click the close (x) icon

wait ...
keep waiting ...

steam still running minimized...
(stdout|stderr did not even notice the click event or at least shows nothing)

hitting the close button does nothing but minimize the steam client.

@nmschulte
Copy link

nmschulte commented Dec 21, 2016

expected behaviour

Application clean exit

Note, this is not the expected behavior of the workaround you referenced. The workaround simply forces the window to close, not the application. The window should not be minimized in a window/task/process panel, but closed entirely. From there, whether or not the application exits (closes) should be determined by your Steam preference to "close to tray" or not (and possibly other "exit behavior" preferences).

I just tested the workaround behavior, and it's working for this version of Steam:
2016_12_21-15_40_22-351x250

I couldn't find a "close to tray?" preference that I was referencing, though, so it may not be possible to have "close" actually exit Steam. At least, not in this version; I thought the pref was real, so maybe it's in newer builds.

@kisak-valve, this issue is not a duplicate of the one you referenced. That one is involved in the strange behavior, but these two issues are simply compounded; this is a separate, real issue.

@nmschulte
Copy link

nmschulte commented Dec 21, 2016

I just updated Steam to the latest version, and the environment variable to workaround issue #1025 (where the close button works like minimize, in Linux releases) is still working just fine.

I cannot find a "close to tray?" preference, though, so it seems impossible to make the close button exit Steam, in the Linux release. @kisak-valve, that problem is what this issue is for. If one fixes the "close button" behavior (via the "workaround" noted), the app stays alive in the app/system tray; it's not configurable.

@alemansec
Copy link
Author

note that the windows build also behaves incorrectly regarding the close button : hit the close button and application will just minimize....

i'm not speaking of any minimize to tray "problem" .. it always worked correctly for me although application lacks quite a few options regarding focus, placement, minimize behaviour and also - because you're using close icon to minimize - close button behaviour.

Give us those options (via environment variables if you don't want those to be "visible" to all of your users).
If you still want to use standard icons like close button to act as non-standard, all-rules-and-standards-breaking, custom weird widgets, at least give us options to make them work as expected :)

[letting window manager actually manage windows, making close icons actually CLOSE the window then application if MainWindow was closed ... in a few words .. proper application, not a winblow$ copy&paste thing ...]

@kisak-valve kisak-valve reopened this Dec 21, 2016
@kisak-valve kisak-valve changed the title window close button not working [Feature Request] Add option for the close button to completely exit steam Dec 21, 2016
@nmschulte
Copy link

nmschulte commented Dec 21, 2016

@kisak-valve, I think the community believes it makes more sense for what's being requested to be the default behavior, and that the option to not exit is the ultimate request.

@kisak-valve
Copy link
Member

@nmschulte, are your asking for #1025, not this issue report?

@nmschulte
Copy link

The two are basically the same, @kisak-valve; this one asks for close to exit the application, and the other one asks for close to close the window (keep the app up in the tray). Personally, I feel like there should simply be a "close to tray" and/or perhaps "minimze to tray" preference, and clicking the X ("closing" Steam) should exit the app if "close to tray" is not selected, and otherwise it should simply close the window and keep Steam running ("in the tray"). Similarly for minimize. That would resolve all of these issues.

Presumably #1025 will never be fix, and so forth neither will this one, or all of the mess that #1025 creates. So, at this point, I go silent and check back in four years.

@Plagman
Copy link
Member

Plagman commented Dec 22, 2016

We have no plans to change that behavior, as it matches the behavior of the client on other platforms.

@Plagman Plagman closed this as completed Dec 22, 2016
@nmschulte
Copy link

nmschulte commented Dec 22, 2016

😮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants