-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrongly played MSX2 track #106
Comments
Hmm...this is actually a bug in the VGM. This used to work fine in the old VGMPlay due to an implementation oddity. |
I.e. this is invalid rip? I suppose youtube version is from real console (or emulator at least) due to quite low quality. |
The rip itself should be mostly okay. There is just a wrong flag set in the VGM header, but this can be easily patched afterwards. I'll probably go further and just check+update all the SCC packs though. |
Snatcher is an SCC+ game, so the flag is correctly set, but it sounds like the commands used are wrong. |
Okay, so then the pack is bad. I checked a few tracks and they all write only to the wave RAM of the first 4 channels. (using the SCC non-plus commands) This issue has one good side though: This confirms that libvgm now behaves like VGMPlay MSX with incorrect SCC/SCC+ flags. (which is a good thing, as it makes incorrect VGM rips more obvious) |
Ping @sdsnatcher73. |
Most likely the issue is then originated in NEZplug v0.9.4.8 + 2 + 19.20 which was used to create the VGM's. It probably does not log the wave data correctly. |
01.vgz.zip |
I guess kss2vgm (used for SD Snatcher) does log correctly, but officially we're not supposed to use that, right? |
New version logged with kss2vgm. Please let me know if this works better... |
Yes, looks like problem is solved. At least, I can't hear any significant difference between reference and updated version |
Here the full pack: https://vgmrips.net/packs/pack/snatcher-msx2
Twilight of Neo Kobe City track sounds different via libvgm and site player.
Here the reference: https://www.youtube.com/watch?v=KbbF9odLDxI
The text was updated successfully, but these errors were encountered: