Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default search field to 'all' #457

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Change default search field to 'all' #457

merged 1 commit into from
Apr 9, 2024

Conversation

otokama
Copy link
Member

@otokama otokama commented Apr 8, 2024

Change default search field to 'all'

Asana Ticket: (link) (:star:)
https://app.asana.com/0/1205959349035436/1206858934896517/f

What does this Pull Request do? (:star:)

Change the default search field from 'title' to 'all'

What's the changes? (:star:)

  • Search bar search field in the home page is set to 'all' by default.
  • Re-ordered all search fields to be in alphabetical order

How should this be tested?

  • In home page or in search result page, the default search field for search bar is set to 'all'.

Interested parties

Tag (@ mention) interested parties
@whunter
@goynejennifer

(:star:) Required fields

@otokama otokama requested a review from whunter April 8, 2024 21:35
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-457.d234tdmg9icdwk.amplifyapp.com

Copy link
Member

@whunter whunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Were we passing the wrong prop name from the ArchivePage before this?

@whunter whunter merged commit d7bd937 into dev Apr 9, 2024
2 checks passed
@whunter whunter deleted the default_search_field branch April 9, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants