Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display page count for each collection item (with IIIF manifest) in search page #456

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

otokama
Copy link
Member

@otokama otokama commented Apr 1, 2024

Page count display for collection item in search page

Asana Ticket: (link) (:star:)
https://app.asana.com/0/1205959349035436/1206958110604741/f

What does this Pull Request do? (:star:)

  • To display page count for each collection item (with IIIF manifest) in search page
  • To change tags layout from vertical to horizontal

What's the changes? (:star:)

  • Populated page count in DynamoDB for collection item with a IIIF manifest
  • Added page count display in both item list view and gallery view under the search page
  • Modified tags display layout to horizontal to it make more space for displaying page count

How should this be tested?

  • In the generated preview site, go to /search page
  • Choose item list view or gallery view
  • Check if the page count is consistent with the actual number of pages by clicking into the archive page

Additional Notes:

  • branch: item-page-count-display

Interested parties

@whunter
@goynejennifer

add more spacing between tags, separate tags by comma
@goynejennifer
Copy link
Collaborator

@otokama Quick question, this check is failing as seen above do I need to wait till it has passed

@otokama
Copy link
Member Author

otokama commented Apr 2, 2024

@otokama Quick question, this check is failing as seen above do I need to wait till it has passed

Yes looks like we had a new backend environment for preview? @whunter

@goynejennifer
Copy link
Collaborator

After preview was released I was able to evaluate the PR and this works as expected. Approving PR

@whunter whunter merged commit 4fd221d into dev Apr 5, 2024
0 of 2 checks passed
@whunter whunter deleted the item-page-count-display branch April 5, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants