From 00a91b89753231f9df19f143a68df1d4f4913de1 Mon Sep 17 00:00:00 2001 From: vsadov Date: Wed, 4 Mar 2020 11:14:54 -0800 Subject: [PATCH] Added comment about revisiting after #5857 is fixed --- src/coreclr/src/vm/ecall.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/coreclr/src/vm/ecall.cpp b/src/coreclr/src/vm/ecall.cpp index 86497a89c1cd2..7231cd3ff8f15 100644 --- a/src/coreclr/src/vm/ecall.cpp +++ b/src/coreclr/src/vm/ecall.cpp @@ -201,6 +201,9 @@ void ECall::PopulateManagedCastHelpers() // so indirection is not as big concern. // We JIT-compile the following helpers eagerly here to avoid indirection costs. + //TODO: revise if this specialcasing is still needed when crossgen supports tailcall optimizations + // see: https://github.com/dotnet/runtime/issues/5857 + pMD = MscorlibBinder::GetMethod((BinderMethodID)(METHOD__CASTHELPERS__STELEMREF)); pMD->DoPrestub(NULL); // This helper is marked AggressiveOptimization and its native code is in its final form.